Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make TSB conformant with respect to multiple parallel operations #18537

Merged
merged 1 commit into from
Feb 15, 2018
Merged

make TSB conformant with respect to multiple parallel operations #18537

merged 1 commit into from
Feb 15, 2018

Conversation

jim-minter
Copy link
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 8, 2018
@jim-minter jim-minter force-pushed the tsb_parallel_bind_unbind branch 2 times, most recently from 3227ee4 to c1e12db Compare February 8, 2018 20:27
@bparees
Copy link
Contributor

bparees commented Feb 8, 2018

worth adding a test that does multiple binds/unbinds concurrently for a few iterations? I know we can't guarantee we hit the conflict but it would be a nice smoke test.

@bparees
Copy link
Contributor

bparees commented Feb 8, 2018

(otherwise lgtm. should be backported to ose:enterprise-3.7 and ose:enteprise-3.8)

@jim-minter jim-minter force-pushed the tsb_parallel_bind_unbind branch 2 times, most recently from 082e04a to 02e836f Compare February 8, 2018 22:04
@jim-minter
Copy link
Contributor Author

tests added, thanks

@bparees
Copy link
Contributor

bparees commented Feb 8, 2018

provision test?

@jim-minter
Copy link
Contributor Author

provision test added.

@bparees
Copy link
Contributor

bparees commented Feb 14, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2018
@bparees bparees added this to the 3.9.0 milestone Feb 14, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 14, 2018
@openshift-merge-robot openshift-merge-robot removed the lgtm Indicates that a PR is ready to be merged. label Feb 14, 2018
@jim-minter
Copy link
Contributor Author

/retest

@bparees
Copy link
Contributor

bparees commented Feb 15, 2018

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 15, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jim-minter

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

Automatic merge from submit-queue (batch tested with PRs 18487, 18537, 18630).

@openshift-merge-robot openshift-merge-robot merged commit a4d6ece into openshift:master Feb 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfojtik mfojtik Awaiting requested review from mfojtik

@spadgett spadgett Awaiting requested review from spadgett

Assignees

@bparees bparees

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-api-review size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v3.9
Development

Successfully merging this pull request may close these issues.
5 participants
@jim-minter @bparees @openshift-ci-robot @openshift-bot @openshift-merge-robot