Fix invalid SuggestFor for oc image #18563
Conversation
openshift-ci-robot
added
the
size/S
|
/retest |
|
/lgtm cc @soltysh |
pkg/oc/cli/cmd/wrappers.go
Outdated
| @@ -480,7 +480,7 @@ func NewCmdRun(fullName string, f *clientcmd.Factory, in io.Reader, out, errout | |||
| cmd := kcmd.NewCmdRunWithOptions(f, opts, in, out, errout) | |||
| cmd.Long = runLong | |||
| cmd.Example = fmt.Sprintf(runExample, fullName) | |||
| cmd.SuggestFor = []string{"image"} | |||
| cmd.SuggestFor = []string{"start"} | |||
There was a problem hiding this comment.
start doesn't seem to be informative here. I'd just drop this suggestion entirely.
There was a problem hiding this comment.
Alright, updated. I have already squashed, as this is small PR.
openshift-merge-robot
removed
the
lgtm
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: juanvallejo, nak3, soltysh The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these OWNERS Files:
You can indicate your approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all [submit-queue is verifying that this PR is safe to merge] |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
Automatic merge from submit-queue. |
This patch has tiny changes as:
oc imagewithoc startfor the suggestion foroc runoc imagefrom the suggetion foroc import-imageoc importis already existing command, so currentSuggestFor: []string{"image"}is not working.