up: write static pod definitions on --write-config #19338
Conversation
openshift-ci-robot
added
approved
mfojtik
force-pushed
the
up-01-write-config
branch
2 times, most recently
from
88d266f
to
2040ac9
Compare
|
/retest centos mirrors... |
| @@ -139,6 +127,18 @@ func (c *ClusterUpConfig) StartSelfHosted(out io.Writer) error { | |||
| } | |||
| } | |||
|
|
|||
| // if we're supposed to write the config, we'll do that and then exit | |||
There was a problem hiding this comment.
Rather than re-ordering here, can we move the static pod creation to the BuildConfig method, since we're treating it as config?
mfojtik
force-pushed
the
up-01-write-config
branch
from
2040ac9
to
b4bad38
Compare
openshift-ci-robot
added
size/M
| substitutions["ETCD_VOLUME"] = `hostPath: | ||
| path: ` + c.HostDataDir + "\n" | ||
| } | ||
| for _, staticPodLocation := range staticPodLocations { |
There was a problem hiding this comment.
you dropped the log statement here, maybe intentionally
There was a problem hiding this comment.
unintentionally, good catch, added it back.
mfojtik
force-pushed
the
up-01-write-config
branch
from
b4bad38
to
161c301
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
/cc @deads2k
/cc @pweil-