add migration for templateinstance status object references #19664
Conversation
openshift-ci-robot
added
size/L
bparees
force-pushed
the
migrate
branch
2 times, most recently
from
4f7a5a2
to
a5ad8f0
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bparees The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
1 similar comment
|
/retest |
| {"BuildConfig", "v1"}: {"BuildConfig", "build.openshift.io/v1"}, | ||
| {"Build", "v1"}: {"Build", "build.openshift.io/v1"}, | ||
| {"Route", "v1"}: {"Route", "route.openshift.io/v1"}, | ||
| // legacy oapi group, for the lazy |
There was a problem hiding this comment.
for the wrong. Do we actually have this anywhere? it shouldn't be valid.
There was a problem hiding this comment.
pulled this from what legacy-hpa was doing... happy to remove it if we don't think it's needed.
| } | ||
|
|
||
| func (o *MigrateTemplateInstancesOptions) checkAndTransform(templateInstanceRaw runtime.Object) (migrate.Reporter, error) { | ||
| templateInstance, wasTI := templateInstanceRaw.(*templateapi.TemplateInstance) |
There was a problem hiding this comment.
optional nit: standard is ok, not wasTI, right?
There was a problem hiding this comment.
ditto, copied from legacyhpa. frankly I like the wasX naming better :)
|
optional nits. /lgtm |
|
/retest |
No description provided.