Make API storage migration less sensitive to conflicts #19916
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change moves the rate limiting logic in migrate storage to after both the GET and PUT have completed (instead of being in between the two operations). This should make the command less sensitive to conflicts caused by resources that change often. Bug 1585511 Signed-off-by: Monis Khan <mkhan@redhat.com>
openshift-ci-robot
added
the
size/S
|
@liggitt no idea if this will actually help the BZ issue. |
openshift-ci-robot
added
the
approved
|
yes, delaying between the get/put seems problematic /lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: enj, liggitt The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/kind bug |
openshift-ci-robot
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves the rate limiting logic in migrate storage to after both the GET and PUT have completed (instead of being in between the two operations). This should make the command less sensitive to conflicts caused by resources that change often.
Bug 1585511
Signed-off-by: Monis Khan mkhan@redhat.com