Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 63926: Avoid unnecessary calls to the cloud provider #20029

Closed
wants to merge 1 commit into from
Closed

UPSTREAM: 63926: Avoid unnecessary calls to the cloud provider #20029

wants to merge 1 commit into from

Conversation

fcami
Copy link
Contributor

@fcami fcami commented Jun 18, 2018 •
edited

If the service controller is processing a service that does not have type
LoadBalancer and does not have any external load balancer recorded in its
status, do not call the cloud provider to check for an associated load
balancer.

This commit fixes bug 1571940
https://bugzilla.redhat.com/show_bug.cgi?id=1571940
and 1583718 for OCP 3.9:
https://bugzilla.redhat.com/show_bug.cgi?id=1583718

(cherry picked from commit aaf46c4)
Author: Miciah Masters miciah.masters@gmail.com
Date: Wed May 16 11:52:25 2018 -0400

@openshift-ci-robot
Copy link

Hi @fcami. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 18, 2018
@Miciah @fcami
UPSTREAM: 63926: Avoid unnecessary calls to the cloud provider
99401c7 
If the service controller is processing a service that does not have type
LoadBalancer and does not have any external load balancer recorded in its
status, do not call the cloud provider to check for an associated load
balancer.

This commit fixes bug 1571940
https://bugzilla.redhat.com/show_bug.cgi?id=1571940
and 1583718 for OCP 3.9:
https://bugzilla.redhat.com/show_bug.cgi?id=1583718

(cherry picked from commit aaf46c4)
Author:    Miciah Masters <miciah.masters@gmail.com>
Date:      Wed May 16 11:52:25 2018 -0400
knobunc
knobunc approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@knobunc knobunc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2018
@knobunc
Copy link
Contributor

knobunc commented Jun 18, 2018

@Miciah This seems reasonable to me. Do you have any concern about merging it?

@Miciah
Copy link
Contributor

Miciah commented Jun 18, 2018 •
edited

Yeah, looks good!

@Miciah
Copy link
Contributor

Miciah commented Jun 18, 2018

/test unit

Looks like #17881.

@knobunc
Copy link
Contributor

knobunc commented Jun 20, 2018

/lgtm
/approve

@knobunc
Copy link
Contributor

knobunc commented Jun 20, 2018

@deads2k @derekwaynecarr will one of you approve this please?

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fcami, knobunc
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: derekwaynecarr

Assign the PR to them by writing /assign @derekwaynecarr in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fcami
Copy link
Contributor Author

fcami commented Jun 27, 2018

@deads2k @derekwaynecarr will one of you approve this please?

@knobunc
Copy link
Contributor

knobunc commented Jun 27, 2018

@deads2k wisely points out that if we want this to go in an errata release we need to do the work in the ose repo. Can you please close this PR and open it there? Thanks

@Miciah
Copy link
Contributor

Miciah commented Jun 27, 2018

I'll take care of it.

@Miciah Miciah closed this Jun 27, 2018
@Miciah
Copy link
Contributor

Miciah commented Jun 27, 2018

Created openshift/ose#1331.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knobunc knobunc knobunc approved these changes

@deads2k deads2k Awaiting requested review from deads2k

@liggitt liggitt Awaiting requested review from liggitt

Assignees

@knobunc knobunc

Labels
lgtm Indicates that a PR is ready to be merged. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@fcami @openshift-ci-robot @knobunc @Miciah