Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md to reflect OKD rebranding #20533

Merged
merged 1 commit into from Aug 3, 2018
Merged

Update README.md to reflect OKD rebranding #20533

merged 1 commit into from Aug 3, 2018

Conversation

stevekuznetsov
Copy link
Contributor

@stevekuznetsov
Update README.md to reflect OKD rebranding
f3cfa8e 
Signed-off-by: Steve Kuznetsov <skuznets@redhat.com>
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stevekuznetsov

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 3, 2018
sudhaponnaganti
sudhaponnaganti reviewed Aug 3, 2018
View reviewed changes
Copy link

@sudhaponnaganti sudhaponnaganti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stevekuznetsov stevekuznetsov added the lgtm Indicates that a PR is ready to be merged. label Aug 3, 2018
@openshift-merge-robot openshift-merge-robot merged commit 342837c into openshift:master Aug 3, 2018
@wking
Copy link
Member

wking commented Dec 2, 2018

Did you want to update the repo description as well? Currently that's still:

$ curl -s https://api.github.com/repos/openshift/origin | jq -r .description
Enterprise Kubernetes for Developers

@wking
Copy link
Member

wking commented Dec 2, 2018

Also:

$ curl -s https://api.github.com/repos/openshift/origin | jq -r .homepage
http://www.openshift.org
$ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
HTTP/1.1 302 Found
Location: https://www.openshift.org/
HTTP/1.1 301 Moved Permanently
Location: https://www.okd.io/
HTTP/1.1 200 OK

wking added a commit to wking/RedHatOfficial.github.io that referenced this pull request Dec 2, 2018
@wking
app/data: Update "OpenShift Origin" -> "OKD"
8c4866b 
Catching up with openshift/origin@f3cfa8ed (Update README.md to
reflect OKD rebranding, 2018-08-03, openshift/origin#20533).  The URL
changes follow the existing redirects:

  $ date --iso=m --utc
  $ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
  2018-12-02T07:25+0000
  HTTP/1.1 302 Found
  Location: https://www.openshift.org/
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/
  HTTP/1.1 200 OK
  $ curl -sIL https://www.openshift.org/minishift/ | grep 'HTTP\|Location'
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/minishift/
  HTTP/1.1 200 OK
@wking wking mentioned this pull request Dec 2, 2018
Merged
wking added a commit to wking/RedHatOfficial.github.io that referenced this pull request Dec 2, 2018
@wking
app/data: Update "OpenShift Origin" -> "OKD"
770a7ae 
Catching up with openshift/origin@f3cfa8ed (Update README.md to
reflect OKD rebranding, 2018-08-03, openshift/origin#20533).  The URL
changes follow the existing redirects:

  $ date --iso=m --utc
  2018-12-02T07:25+0000
  $ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
  HTTP/1.1 302 Found
  Location: https://www.openshift.org/
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/
  HTTP/1.1 200 OK
  $ curl -sIL https://www.openshift.org/minishift/ | grep 'HTTP\|Location'
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/minishift/
  HTTP/1.1 200 OK
wking added a commit to wking/RedHatOfficial.github.io that referenced this pull request Dec 2, 2018
@wking
app/data: Update "OpenShift Origin" -> "OKD"
2e7a42e 
Catching up with openshift/origin@f3cfa8ed (Update README.md to
reflect OKD rebranding, 2018-08-03, openshift/origin#20533).  The URL
changes follow the existing redirects:

  $ date --iso=m --utc
  2018-12-02T07:25+0000
  $ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
  HTTP/1.1 302 Found
  Location: https://www.openshift.org/
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/
  HTTP/1.1 200 OK
  $ curl -sIL https://www.openshift.org/minishift/ | grep 'HTTP\|Location'
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/minishift/
  HTTP/1.1 200 OK

I've included a trailing period in featured.json but not in
projects.json to match the apparent conventions in both files.
wking added a commit to wking/RedHatOfficial.github.io that referenced this pull request Dec 2, 2018
@wking
app/data: Update "OpenShift Origin" -> "OKD"
ca71e49 
Catching up with openshift/origin@f3cfa8ed (Update README.md to
reflect OKD rebranding, 2018-08-03, openshift/origin#20533).  The URL
changes follow the existing redirects:

  $ date --iso=m --utc
  2018-12-02T07:25+0000
  $ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
  HTTP/1.1 302 Found
  Location: https://www.openshift.org/
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/
  HTTP/1.1 200 OK
  $ curl -sIL https://www.openshift.org/minishift/ | grep 'HTTP\|Location'
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/minishift/
  HTTP/1.1 200 OK

I've included a trailing period in featured.json but not in
projects.json to match the apparent conventions in both files.
wking added a commit to wking/RedHatOfficial.github.io that referenced this pull request Dec 2, 2018
@wking
app/data: Update "OpenShift Origin" -> "OKD"
811292f 
Catching up with openshift/origin@f3cfa8ed (Update README.md to
reflect OKD rebranding, 2018-08-03, openshift/origin#20533).  The URL
changes follow the existing redirects:

  $ date --iso=m --utc
  2018-12-02T07:25+0000
  $ curl -sIL http://www.openshift.org | grep 'HTTP\|Location'
  HTTP/1.1 302 Found
  Location: https://www.openshift.org/
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/
  HTTP/1.1 200 OK
  $ curl -sIL https://www.openshift.org/minishift/ | grep 'HTTP\|Location'
  HTTP/1.1 301 Moved Permanently
  Location: https://www.okd.io/minishift/
  HTTP/1.1 200 OK

I've included a trailing period in featured.json but not in
projects.json to match the apparent conventions in both files.

The new logo was created from the okd.io SVG (as of
openshift-cs/okd.io@e1b69575, Fix double space, 2018-12-01) with:

  $ git diff -U0
  diff --git a/source/img/okd_logo.svg b/source/img/okd_logo.svg
  index 8e470ce..de29a54 100644
  --- a/source/img/okd_logo.svg
  +++ b/source/img/okd_logo.svg
  @@ -7 +7 @@
  -	 .st1{fill:#FFFFFF;}
  +	 .st1{fill:#000000;}
  $ inkscape --without-gui --export-png=logo-okd.png --export-dpi=200 --export-background-opacity=0 --export-area-drawing source/img/okd_logo.svg

using:

  $ inkscape --version
  Inkscape 0.92.2 (5c3e80d, 2017-08-06)

I guessed at the DPI to get a logo with a height in the vicinity of
the other logos.  Personally, I'd be happier with vector source; the
upstream SVG is smaller (1.8 KB vs. this PNG's 12 KB) and means I
don't have to care how much resolution this site needs.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudhaponnaganti sudhaponnaganti sudhaponnaganti left review comments

@dmueller2001 dmueller2001 dmueller2001 approved these changes

@coverprice coverprice Awaiting requested review from coverprice

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@stevekuznetsov @openshift-ci-robot @wking @dmueller2001 @sudhaponnaganti @openshift-merge-robot