UPSTREAM: 66835: cloudprovider: aws: return true on existence check for stopped instances

[sjenning]

kubernetes/kubernetes#66835

xref https://bugzilla.redhat.com/show_bug.cgi?id=1559271

fixes #19899

@derekwaynecarr @jsafrane @liggitt

[derekwaynecarr]

upstream directional change is blessed, but we can carry this in the interim pending it merge upstream.

/approve
/lgtm

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[sjenning]

/retest

[gnufied]

There are couple of things that needs verified. Please do not merge this without approval from @openshift/sig-storage

/hold

[gnufied]

Things that needs to be verified before we merge this:

a. We need to make sure that, nodes that are shutdown can have its pod migrated without attach/detach issues when node object is still around.
b. We need to make sure that - volumes get detached from static pods(not backed by rc/rs) when a node is down for long period of time.
c. We need to make sure that - there are no race conditions for AWS as mentioned in kubernetes/kubernetes#52735 wrt to attach/detach controller attempting to reattach volumes to terminated nodes because on terminate AWS detaches all volumes from node but this PR will keep the node object still around and hence attach/detach controller will consider this as error state and try to "fix" it.

[sjenning]

@gnufied re: our discussions on IRC, I think you ok with this now right? If so, please comment confirming and re-add lgtm. @derekwaynecarr already approved. Thanks!

[gnufied]

Yeah I think I am okay with merging this with master. storage team will backport the other fix for detaching volume from shutdown node.

/hold cancel

[gnufied]

/lgtm

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, gnufied, sjenning

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• vendor/k8s.io/kubernetes/pkg/cloudprovider/providers/aws/OWNERS [derekwaynecarr,gnufied]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[gnufied]

Filed https://bugzilla.redhat.com/show_bug.cgi?id=1622175 for tracking the storage bug of volumes not getting detached from stopped AWS nodes.