Support bash-completion #2090
Support bash-completion #2090
Conversation
|
Can you split this into a few commits? The first should be the core code that can generate docs, the second should be the changes necessary to cleanup the docs/scripts/completions, and the third should be any of the generated code. Thanks |
|
Sure, I did it. |
|
Handing off to Fabiano for review |
|
Reviewing, @eparis you may want to jump in too. |
|
|
||
| flags+=("--filename=") | ||
| flags_with_completion+=("--filename") | ||
| flags_completion+=("_filedir '@(json|yaml|yml)'") |
There was a problem hiding this comment.
|
I included this request pull/8039 Now I think I fixed all reviewed points. |
| __osc_get_containers() | ||
| { | ||
| local template | ||
| template="{{ range .desiredState.manifest.containers }}{{ .name }} {{ end }}" |
There was a problem hiding this comment.
Isn't this still broken? Move to v1beta3 template form and LGTM
|
@eparis Thank you so much. |
|
LGTM [merge] |
|
continuous-integration/openshift-jenkins/merge SUCCESS (https://ci.openshift.redhat.com/jenkins/job/merge_pull_requests_origin/1931/) (Image: devenv-fedora_1513) |
|
Evaluated for origin up to 0912dd3 |
This PR adds bash-completion support.
Running
$./hack/run-gendoc.shwill create bash-completion scriptsrel-eng/completions/bash/{openshift,osc,osadm}