Don't allow mixing "multiple-egress-IP HA" with "auto-allocated-egress-IP HA" #20971
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have two different ways to do egress IP HA:
egressCIDRs
, and let the master move the egress IP between nodes if one node goes down.So clearly someone's going to say "oh boy, I'll use both and then get twice as much high availability!" This is a terrible idea because what will actually happen is:
So you get twice as much disruption as you would have gotten if you were only using one of the two forms of HA. So this fixes it so that we don't do auto-allocation for egress IPs that are being used as part of multiple-egress-IP HA.