Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove jenkins autoprovision logic+config #21348

Merged
merged 1 commit into from
Oct 30, 2018
Merged

remove jenkins autoprovision logic+config #21348

merged 1 commit into from
Oct 30, 2018

Conversation

bparees
Copy link
Contributor

@bparees bparees commented Oct 24, 2018

No description provided.

@openshift-ci-robot openshift-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Oct 24, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 24, 2018
@bparees bparees force-pushed the jenkins_auto branch 4 times, most recently from aa97c0f to f5fc8b4 Compare October 24, 2018 20:15
@bparees bparees changed the title [WIP] remove jenkins autoprovision logic+config remove jenkins autoprovision logic+config Oct 24, 2018
@openshift-ci-robot openshift-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 24, 2018
@bparees
Copy link
Contributor Author

bparees commented Oct 24, 2018

@deads2k ok i think i stripped this down to the parts you need, ptal.

/assign @deads2k

@bparees
Copy link
Contributor Author

bparees commented Oct 24, 2018

@gabemontero fyi

@gabemontero
Copy link
Contributor

Perhaps on your to-do list since this is WIP @bparees but we'll need to update https://github.com/openshift/origin/tree/master/examples/jenkins/pipeline/README.md to list for each sample the jenkins template needs to be new-app'ed before the sample template.

@bparees
Copy link
Contributor Author

bparees commented Oct 24, 2018

Perhaps on your to-do list since this is WIP @bparees but we'll need to update https://github.com/openshift/origin/tree/master/examples/jenkins/pipeline/README.md to list for each sample the jenkins template needs to be new-app'ed before the sample template.

it was not, thanks. and of course there are product docs that will need updating as well.

/cc @bmcelvee

@bparees
Copy link
Contributor Author

bparees commented Oct 25, 2018

/retest

@deads2k you really want to review this before someone changes their mind :)

@deads2k
Copy link
Contributor

deads2k commented Oct 29, 2018

I'm glad to see this. We'll pick up stragglers when we start snipping out old API.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, deads2k

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2018
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@bparees bparees added the lgtm Indicates that a PR is ready to be merged. label Oct 29, 2018
@openshift-merge-robot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor Author

bparees commented Oct 29, 2018

/retest

1 similar comment
@bparees
Copy link
Contributor Author

bparees commented Oct 29, 2018

/retest

@openshift-merge-robot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-merge-robot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Oct 29, 2018 •
edited
Loading

@bparees: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/openshift-jenkins/extended_clusterup f5fc8b4 link /test extended_clusterup
ci/openshift-jenkins/extended_builds f5fc8b4 link /test extended_builds

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1a1fef8 into openshift:master Oct 30, 2018
@bparees bparees deleted the jenkins_auto branch November 12, 2018 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csrwng csrwng Awaiting requested review from csrwng

@enj enj Awaiting requested review from enj

@bmcelvee bmcelvee Awaiting requested review from bmcelvee

Assignees

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bparees @gabemontero @deads2k @openshift-ci-robot @openshift-merge-robot