Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UPSTREAM: 00000: wait for CRD discovery to be successful once before #22149

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Feb 26, 2019

Working version of #22146

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 26, 2019
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 26, 2019
@mfojtik mfojtik force-pushed the mfojtik-wait-for-crd-discovery branch from a3be5d2 to 53f8121 Compare February 26, 2019 10:51
@openshift-ci-robot openshift-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Feb 26, 2019
@mfojtik mfojtik force-pushed the mfojtik-wait-for-crd-discovery branch from 53f8121 to a2f4dc9 Compare February 26, 2019 12:07
@openshift-ci-robot
Copy link

openshift-ci-robot commented Feb 26, 2019

@mfojtik: The following test failed for commit a2f4dc9, say /retest to rerun them:

Test name Details Rerun command
ci/prow/e2e-aws-serial link /test e2e-aws-serial

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@@ -377,6 +377,8 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag
resourcePath = itemPath
resourceParams = nameParams
}
apiResource.Group = a.group.GroupVersion.Group
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are only normally set if they are different. I suppose its not strictly wrong though.

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 26, 2019

/retest

aws flake

@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 26, 2019

/retest

known flakes

@deads2k
Copy link
Contributor

deads2k commented Feb 26, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik mfojtik added queue/critical-fix priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Feb 26, 2019
@mfojtik
Copy link
Contributor Author

mfojtik commented Feb 26, 2019

@deads2k button?

/retest

@deads2k
Copy link
Contributor

deads2k commented Feb 26, 2019

serial is a known flake. This could improve our health check for a theoretical GC issue. merging

@deads2k deads2k merged commit 9ffad07 into openshift:master Feb 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. queue/critical-fix size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants