-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UPSTREAM: 00000: wait for CRD discovery to be successful once before #22149
UPSTREAM: 00000: wait for CRD discovery to be successful once before #22149
Conversation
a3be5d2
to
53f8121
Compare
53f8121
to
a2f4dc9
Compare
@mfojtik: The following test failed for commit a2f4dc9, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@@ -377,6 +377,8 @@ func (a *APIInstaller) registerResourceHandlers(path string, storage rest.Storag | |||
resourcePath = itemPath | |||
resourceParams = nameParams | |||
} | |||
apiResource.Group = a.group.GroupVersion.Group |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are only normally set if they are different. I suppose its not strictly wrong though.
/retest aws flake |
/retest known flakes |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@deads2k button? /retest |
serial is a known flake. This could improve our health check for a theoretical GC issue. merging |
Working version of #22146