Bug 1620608: Fix dc adoption #22324
Bug 1620608: Fix dc adoption #22324
Conversation
openshift-ci-robot
added
size/L
| @@ -160,8 +160,6 @@ func ValidateDeploymentConfigStatusUpdate(newConfig *appsapi.DeploymentConfig, o | |||
| statusPath := field.NewPath("status") | |||
| if newConfig.Status.LatestVersion < oldConfig.Status.LatestVersion { | |||
| allErrs = append(allErrs, field.Invalid(statusPath.Child("latestVersion"), newConfig.Status.LatestVersion, "latestVersion cannot be decremented")) | |||
| } else if newConfig.Status.LatestVersion > (oldConfig.Status.LatestVersion + 1) { | |||
| allErrs = append(allErrs, field.Invalid(statusPath.Child("latestVersion"), newConfig.Status.LatestVersion, "latestVersion can only be incremented by 1")) | |||
There was a problem hiding this comment.
loosening the validation seems ok, if we won't start using it until it is present in the supported version skew
@smarterclayton wdyt?
tnozicka
force-pushed
the
fix-dc-adoption
branch
from
c5f5180
to
3031d45
Compare
tnozicka
force-pushed
the
fix-dc-adoption
branch
from
3031d45
to
829437f
Compare
tnozicka
force-pushed
the
fix-dc-adoption
branch
from
829437f
to
7ca3f26
Compare
|
/retest |
|
/cherrypick master |
|
@tnozicka: once the present PR merges, I will cherry-pick it on top of master in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mfojtik, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@tnozicka: new pull request created: #22409 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.1 |
|
@tnozicka: new pull request created: #23648 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=1620608
/cc @mfojtik