switch integration tests to external kubeclient #22382
Conversation
openshift-ci-robot
added
size/XXL
deads2k
force-pushed
the
pre-base-18-external-integration
branch
from
afd9803
to
54de9bc
Compare
| @@ -689,21 +689,3 @@ func assertEnvVarEquals(name string, value string, deployment *kapi.ReplicationC | |||
|
|
|||
| t.Fatalf("Expected env var with name %s and value %s", name, value) | |||
| } | |||
|
|
|||
| func makeStream(name, tag, dir, image string) *imageapi.ImageStream { | |||
| if err != nil || len(sa.Secrets) == 0 { | ||
| return false, nil | ||
| } | ||
| return true, nil | ||
| }) | ||
| if err != nil { |
| if err != nil { | ||
| return false, err | ||
| } | ||
| for i := range allSecrets.Items { | ||
| secret := &allSecrets.Items[i] | ||
| secretv1 := &corev1.Secret{} |
| @@ -0,0 +1,244 @@ | |||
| /* | |||
There was a problem hiding this comment.
I don't see any reasons we would not want to have that on our end and not an upstream, but I might be missing some greater picture you have.
There was a problem hiding this comment.
I don't see any reasons we would not want to have that on our end and not an upstream, but I might be missing some greater picture you have.
it comes in with the rebase. This just makes workable early
There was a problem hiding this comment.
Can you add that to the list of followups so we don't forget about it?
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
No description provided.