text/extended: Check both IP and Hostname on LB #22872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some platforms may set an IP address and not set a host name on LoadBalancer services, so check both fields. * test/extended/router/router.go (waitForNamedRouterServiceIP): Check both IP and Hostname. Delete check for the service name that was used in v3.
* test/extended/router/headers.go: * test/extended/router/metrics.go: * test/extended/router/reencrypt.go: Use WaitForRouterServiceIP and WaitForRouterInternalIP from the exutil package. * test/extended/router/router.go: Move waitForRouterInternalIP, waitForRouterExternalIP, routerShouldHaveExternalService, waitForRouterServiceIP, and waitForNamedRouterServiceIP from here... * test/extended/util/router.go: ...to here. Rename waitForRouterServiceIP to WaitForRouterServiceIP and waitForRouterInternalIP to WaitForRouterInternalIP.
openshift-ci-robot
added
the
size/L
/test unit /test e2e-aws Edit: First flake looks like BZ#1711563. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ironcladlou, Miciah The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test/extended: Move some helpers toutil/router.gotest/extended/router/headers.go:test/extended/router/metrics.go:test/extended/router/reencrypt.go: UseWaitForRouterServiceIPandWaitForRouterInternalIPfrom theexutilpackage.test/extended/router/router.go: MovewaitForRouterInternalIP,waitForRouterExternalIP,routerShouldHaveExternalService,waitForRouterServiceIP, andwaitForNamedRouterServiceIPfrom here...test/extended/util/router.go: ...to here. RenamewaitForRouterServiceIPtoWaitForRouterServiceIPandwaitForRouterInternalIPtoWaitForRouterInternalIP.text/extended: Check bothIPandHostnameon LBSome platforms may set an IP address and not set a host name on LoadBalancer services, so check both fields.
test/extended/router/router.go(waitForNamedRouterServiceIP): Check bothIPandHostname. Delete check for the service name that was used in v3.