Revert "test/extended/util: allow tests to be skipped based on platform" #23299
Conversation
openshift-ci-robot
added
the
size/M
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
| if e2e.TestContext.Provider != "" { | ||
| excludedTests = append(excludedTests, fmt.Sprintf(`\[Skipped:%s\]`, e2e.TestContext.Provider)) | ||
| } | ||
| excludedTestsFilter := regexp.MustCompile(strings.Join(excludedTests, `|`)) |
There was a problem hiding this comment.
This line specifically is inside of an O(N^2) loop.
|
@abhinavdahiya can you re-open the revert of the revert and move that line outside of the for loop - should fix your issue. Note that we use contains vs regex because of the perf cost (each sub shell process has to look at all tests for all skip lists) |
|
/retest |
|
Force merging to relieve the CI env of the CPU overload. |
|
@smarterclayton: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Reverts #23245
Appears to have caused a significant CPU spike, which is likely due to the new skip rules being treated as wildcards (there's an O(N^2) factor in skip rules if you're not careful.)