check ServiceCatalog basic usages in OCP 4.x #23352

jianzhangbjz · 2019-07-10T11:18:45Z

This PR will cover ServiceCatalog test cases: OCP-24062, OCP-24049, OCP-15600. @jmrodri @shawn-hurley @bparees Could you help have a review? Thanks! cc: @bandrade @scolange @cuipinghuo @chengzhang1016 @zihantang-rh @emmajiafan

jianzhangbjz · 2019-07-10T11:21:15Z

/assign @jmrodri @bparees

jmrodri · 2019-07-10T20:37:03Z

@jianzhangbjz I'll review it tomorrow (July 11th)

jianzhangbjz · 2019-07-12T10:52:42Z

/retest

jianzhangbjz · 2019-07-12T11:21:56Z

@jmrodri Thanks! I'm looking forward to your comments.

jianzhangbjz · 2019-07-15T01:44:52Z

/test e2e-aws

jmrodri

Looks fine to me. Nothing stands out.

jianzhangbjz · 2019-07-15T07:18:26Z

@bparees Could you help take a look below errors? I have no idea why it uses ci-op-v9kp4jjx namespace. :(

fail [github.com/openshift/origin/test/extended/operators/service_catalog.go:94]: Unexpected error:
    <*util.ExitError | 0xc003fea660>: {
        Cmd: "oc --config=/tmp/admin.kubeconfig process -f /tmp/fixture-testdata-dir654606588/test/extended/testdata/service_catalog/ups-deployment.yaml -p NAMESPACE=e2e-test-service-catalog-97jk7",
        StdErr: "error: unable to process template\n  namespaces \"ci-op-v9kp4jjx\" not found",

shawn-hurley · 2019-07-15T12:13:25Z

/retest

bparees · 2019-07-15T19:35:52Z

@bparees Could you help take a look below errors? I have no idea why it uses ci-op-v9kp4jjx namespace. :(

i don't either, it looks right to me.

/retest

bparees · 2019-07-15T22:47:25Z

test/extended/testdata/service_catalog/ups-deployment.yaml

+      heritage: Tiller
+      release: ups-broker
+    name: ups-broker
+    namespace: "${NAMESPACE}"


just in case, can you use a different name for this parameter in case somehow things are being tripped by NAMESPACE being a special value?

i don't think it's the issue but it's an easy thing to try.

bparees · 2019-07-15T22:49:17Z

The implication of the error you're getting is that the oc binary is using a namespace that doesn't exist (namely it looks like it's using the namespace that the CI job pod is running under, which doesn't make much sense to me):

oc process -f /tmp/template.yaml -p NAMESPACE=test -n nonexistent
error: unable to process template
  namespaces "nonexistent" not found

bparees · 2019-07-15T22:52:58Z

test/extended/operators/service_catalog.go

+var _ = g.Describe("[Feature:Platform] Service Catalog should", func() {
+	defer g.GinkgoRecover()
+
+	var oc = exutil.NewCLI("service-catalog", exutil.KubeConfigPath()).WithoutNamespace()


it's possible this is your issue. Why are you choosing "withoutnamespace"? This means your oc invocations will not have a -n arg added to them for the namespace your e2e test is running in.

I thought I have to add --namespace value for each oc command if I don't use WithoutNamespace(). So, I used it.

i think you have that backwards.

Remove the WithoutNamespace() func and it works now, thanks!

jianzhangbjz · 2019-07-16T10:07:03Z

Seems like Service Catalog Operator doesn't support change status to Removed from Unmanaged. That also means if the user wants to disable Service Catalog, they have to change the status to Managed first. Is it as expected? @jmrodri @shawn-hurley

fail [github.com/openshift/origin/test/extended/operators/service_catalog.go:72]: Expected
    <string>: [map[lastTransitionTime:2019-07-16T06:24:10Z message:the apiserver is in the desired state (Removed). reason:Removed status:True type:Available] map[lastTransitionTime:2019-07-16T06:17:15Z reason:Removed status:False type:Progressing] map[lastTransitionTime:2019-07-16T05:41:53Z reason:Removed status:False type:Degraded] map[lastTransitionTime:2019-07-16T06:17:06Z reason:NoUnsupportedConfigOverrides status:True type:UnsupportedConfigOverridesUpgradeable] map[lastTransitionTime:2019-07-16T06:17:06Z status:False type:ResourceSyncControllerDegraded] map[lastTransitionTime:2019-07-16T06:17:12Z status:False type:WorkloadDegraded]]
to contain substring
    <string>: RemovalRequestIgnored

shawn-hurley · 2019-07-16T12:01:55Z

Yes, that is correct and by design we are working on a fix for it, you can see this bug for more info: https://bugzilla.redhat.com/show_bug.cgi?id=1710937

jianzhangbjz · 2019-07-17T08:55:38Z

@shawn-hurley Yes, thanks! But bug 1710937, it related to removing Service Catalog. And the current issue is that Service Catalog Operator doesn't support change Unmanaged to Removed. Is it as expected? If yes, why add this restriction?

jianzhangbjz · 2019-07-18T08:21:52Z

/test e2e-aws

jianzhangbjz · 2019-07-19T02:59:06Z

/test e2e-aws

jianzhangbjz · 2019-07-19T02:59:58Z

/test e2e-aws

jianzhangbjz · 2019-07-21T02:44:29Z

/test e2e-aws

jianzhangbjz · 2019-07-22T10:41:57Z

/test e2e-aws

jianzhangbjz · 2019-07-24T09:53:25Z

/retest

jianzhangbjz · 2019-12-04T02:48:34Z

Anyone can help fix this account problem for GCP: your Red Hat account is not enabled for remote support or your token has expired? Or am I missing something? Thanks! @bparees @smarterclayton

level=info msg="Cluster operator support Disabled is True with NotAuthorized: Reporting was not allowed: your Red Hat account is not enabled for remote support or your token has expired"
level=fatal msg="failed to initialize the cluster: Cluster operator console has not yet reported success"

bparees · 2019-12-04T04:01:48Z

@jianzhangbjz try pinging the @dpp-team in #forum-dp-platform or if you think our GCP account is fundamentally broken you can escalate to @dptp-triage in #4-dev-triage

but i'm not seeing evidence this is consistently failing across PRs:
https://prow.svc.ci.openshift.org/job-history/origin-ci-test/pr-logs/directory/pull-ci-openshift-origin-master-e2e-gcp

jianzhangbjz · 2019-12-05T12:58:37Z

/test e2e-gcp

jianzhangbjz · 2019-12-06T01:14:29Z

/retest

jianzhangbjz · 2019-12-06T09:01:55Z

/test e2e-gcp

jianzhangbjz · 2019-12-09T07:13:41Z

/test e2e-gcp

jianzhangbjz · 2019-12-10T10:18:42Z

/retest

jianzhangbjz · 2019-12-12T01:19:16Z

/test e2e-gcp

jianzhangbjz · 2019-12-12T08:46:03Z

@shawn-hurley Could you help add the /approve label? Thanks! I think @jmrodri and I only have the lgtm permission.

shawn-hurley · 2019-12-13T03:51:16Z

/approve

openshift-ci-robot · 2019-12-13T03:54:08Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jianzhangbjz, jmrodri, shawn-hurley

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~test/extended/OWNERS~~ [shawn-hurley]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-bot · 2019-12-13T04:06:07Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T04:19:06Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T06:03:03Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T06:16:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T11:28:49Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T13:12:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2019-12-13T17:15:13Z

@jianzhangbjz: The following tests failed, say /retest to rerun them all:

Test name	Commit	Details	Rerun command
ci/prow/e2e-aws-upgrade	`48a591c`	link	`/test e2e-aws-upgrade`
ci/prow/artifacts	`48a591c`	link	`/test artifacts`
ci/prow/e2e-aws	`05d04c8`	link	`/test e2e-aws`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2019-12-13T17:25:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2019-12-13T17:39:20Z

/retest

Please review the full test history for this PR and help us cut down flakes.

tnozicka · 2019-12-17T08:13:33Z

test/extended/testdata/service_catalog/ups-deployment.yaml

+  name: ups-deployment-template
+objects:
+- apiVersion: extensions/v1beta1
+  kind: Deployment


extensions/v1beta1 are deprecated for a long time and removed in kube already, followed by removal in 4.4, correct is apps/v1

check ServiceCatalog basic usages in OCP 4.1

check ServiceCatalog basic usages in OCP 4.2

openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 10, 2019

openshift-ci-robot requested review from adambkaplan and gabemontero July 10, 2019 11:18

openshift-ci-robot assigned bparees and jmrodri Jul 10, 2019

jianzhangbjz force-pushed the service-catalog branch 2 times, most recently from 6e44e5a to b6ca3c2 Compare July 12, 2019 10:09

openshift-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 12, 2019

jmrodri approved these changes Jul 15, 2019

View reviewed changes

bparees reviewed Jul 15, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 3, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 13, 2019

openshift-merge-robot merged commit 68b9a89 into openshift:master Dec 13, 2019

jianzhangbjz deleted the service-catalog branch December 15, 2019 02:17

tnozicka reviewed Dec 17, 2019

View reviewed changes

shawn-hurley mentioned this pull request Dec 17, 2019

Bug 1784334: Revert "check ServiceCatalog basic usages in OCP 4.x" #24315

Closed

jianzhangbjz pushed a commit to jianzhangbjz/origin that referenced this pull request Dec 25, 2019

Merge pull request openshift#23352 from jianzhangbjz/service-catalog

b8fc337

check ServiceCatalog basic usages in OCP 4.1

openshift-ci-robot mentioned this pull request Dec 25, 2019

Bug 1786409: Merge pull request #23352 from jianzhangbjz/service-catalog #24349

Closed

jianzhangbjz pushed a commit to jianzhangbjz/origin that referenced this pull request Dec 25, 2019

Merge pull request openshift#23352 from jianzhangbjz/service-catalog

50cea60

check ServiceCatalog basic usages in OCP 4.2

openshift-ci-robot mentioned this pull request Dec 25, 2019

Bug 1786411: Merge pull request #23352 from jianzhangbjz/service-catalog in OCP 42 #24350

Closed

check ServiceCatalog basic usages in OCP 4.x #23352

check ServiceCatalog basic usages in OCP 4.x #23352

Conversation

jianzhangbjz commented Jul 10, 2019

jianzhangbjz commented Jul 10, 2019

jmrodri commented Jul 10, 2019

jianzhangbjz commented Jul 12, 2019

jianzhangbjz commented Jul 12, 2019

jianzhangbjz commented Jul 15, 2019

jmrodri left a comment

Choose a reason for hiding this comment

jianzhangbjz commented Jul 15, 2019

shawn-hurley commented Jul 15, 2019

bparees commented Jul 15, 2019

bparees Jul 15, 2019

Choose a reason for hiding this comment

bparees commented Jul 15, 2019

bparees Jul 15, 2019

Choose a reason for hiding this comment

jianzhangbjz Jul 16, 2019

Choose a reason for hiding this comment

bparees Jul 16, 2019

Choose a reason for hiding this comment

jianzhangbjz Jul 16, 2019

Choose a reason for hiding this comment

jianzhangbjz commented Jul 16, 2019

shawn-hurley commented Jul 16, 2019 • edited

jianzhangbjz commented Jul 17, 2019

jianzhangbjz commented Jul 18, 2019

jianzhangbjz commented Jul 19, 2019

jianzhangbjz commented Jul 19, 2019

jianzhangbjz commented Jul 21, 2019

jianzhangbjz commented Jul 22, 2019

jianzhangbjz commented Jul 24, 2019

jianzhangbjz commented Dec 4, 2019

bparees commented Dec 4, 2019

jianzhangbjz commented Dec 5, 2019

jianzhangbjz commented Dec 6, 2019

jianzhangbjz commented Dec 6, 2019

jianzhangbjz commented Dec 9, 2019

jianzhangbjz commented Dec 10, 2019

jianzhangbjz commented Dec 12, 2019

jianzhangbjz commented Dec 12, 2019

shawn-hurley commented Dec 13, 2019

openshift-ci-robot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

openshift-ci-robot commented Dec 13, 2019 • edited

openshift-bot commented Dec 13, 2019

openshift-bot commented Dec 13, 2019

tnozicka Dec 17, 2019

Choose a reason for hiding this comment

shawn-hurley commented Jul 16, 2019 •

edited

openshift-ci-robot commented Dec 13, 2019 •

edited