Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: 1699146: UPSTREAM: 79940: Avoid RbdDiskManager's DetachDisk function never be executed again #23402

Merged
merged 1 commit into from Jul 26, 2019

Conversation

jsafrane
Copy link
Contributor

@openshift-ci-robot openshift-ci-robot added sig/storage size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 17, 2019
@jsafrane jsafrane changed the title Bugzilla: 1699146: UPSTREAM: 79940: Avoid RbdDiskManager's DetachDisk function never be executed again Bug: 1699146: UPSTREAM: 79940: Avoid RbdDiskManager's DetachDisk function never be executed again Jul 17, 2019
@bertinatto
Copy link
Member

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 17, 2019
@jsafrane
Copy link
Contributor Author

/approve
I should be owner of all k8s pkg/volume.

@jsafrane
Copy link
Contributor Author

hey,

@jsafrane
Copy link
Contributor Author

/assign @mfojtik for approval

@openshift-ci-robot
Copy link

@jsafrane: GitHub didn't allow me to assign the following users: for, approval.

Note that only openshift members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @mfojtik for approval

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mfojtik
Copy link
Member

mfojtik commented Jul 26, 2019

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bertinatto, jsafrane, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 26, 2019
@openshift-merge-robot openshift-merge-robot merged commit 4d9f17e into openshift:master Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. sig/storage size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants