Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1731191: Flaky htpasswd e2e #23421

Merged
merged 1 commit into from
Aug 14, 2019
Merged

Bug 1731191: Flaky htpasswd e2e #23421

merged 1 commit into from
Aug 14, 2019

Conversation

sallyom
Copy link
Contributor

@sallyom sallyom commented Jul 18, 2019 •
edited
Loading

Removing 'Flaky' from htpasswd e2e, running through CI - should not require retry

testing flakiness with this merge: 111a801

/assign @deads2k

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 18, 2019
@sallyom sallyom changed the title Add retry to oauth htpasswd e2e Bug 1731191: Add retry to oauth htpasswd e2e Jul 18, 2019
@openshift-ci-robot
Copy link

@sallyom: This pull request references a valid Bugzilla bug. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1731191: Add retry to oauth htpasswd e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jul 18, 2019
@tnozicka
Copy link
Contributor

/retest

2 similar comments
@sallyom
Copy link
Contributor Author

sallyom commented Jul 19, 2019

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Jul 19, 2019

/retest

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 25, 2019
@sallyom sallyom force-pushed the add-retry-htpasswd-e2e branch 2 times, most recently from d0c212c to 06fd8fc Compare July 25, 2019 23:49
@sallyom
Copy link
Contributor Author

sallyom commented Jul 26, 2019

/retest

@stlaz
Copy link
Contributor

stlaz commented Jul 29, 2019

Since route being inaccessible is the main suspect here, wouldn't it be easier to add a wait for it at https://github.com/openshift/origin/blob/master/test/extended/util/oauthserver/oauthserver.go#L183? (while perhaps keeping the logic for re-retrieving the token options if their state-renewal is important)

@sanchezl
Copy link
Contributor

Since route being inaccessible is the main suspect here, wouldn't it be easier to add a wait for it ...

I added a check for RBAC in #23462. I concur that we can use a check for route also.

@sallyom
Copy link
Contributor Author

sallyom commented Jul 31, 2019

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2019
@sanchezl
Copy link
Contributor

sanchezl commented Aug 1, 2019

This PR should not be needed after #23528 (with further cleanup in #23462). The only thing that might still need doing it removing the "[Flaky]" text from the test spec.

@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2019
@openshift-ci-robot openshift-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 5, 2019
@openshift-ci-robot
Copy link

@sallyom: This pull request references a valid Bugzilla bug.

In response to this:

Bug 1731191: Add retry to oauth htpasswd e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sallyom sallyom changed the title Bug 1731191: Add retry to oauth htpasswd e2e Bug 1731191: Flaky htpasswd e2e Aug 5, 2019
@sallyom
Copy link
Contributor Author

sallyom commented Aug 5, 2019

b4 removing flaky label, will be testing several times

@sallyom sallyom mentioned this pull request Aug 5, 2019
Merged
@openshift-ci-robot openshift-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2019
@openshift-ci-robot openshift-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 6, 2019
@sanchezl
Copy link
Contributor

sanchezl commented Aug 6, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2019
@stlaz
Copy link
Contributor

stlaz commented Aug 7, 2019

/retest

@sallyom
Copy link
Contributor Author

sallyom commented Aug 7, 2019 •
edited
Loading

There have been 8 successful runs of the htpasswd e2e (i've been keeping count), no flakes.. keep going?

@sallyom
Copy link
Contributor Author

sallyom commented Aug 7, 2019

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 7, 2019
@enj
Copy link
Contributor

enj commented Aug 13, 2019

There have been 8 successful runs of the htpasswd e2e (i've been keeping count), no flakes.. keep going?

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: enj, sallyom, sanchezl

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 232e380 into openshift:master Aug 14, 2019
@openshift-ci-robot
Copy link

@sallyom: All pull requests linked via external trackers have merged. The Bugzilla bug has been moved to the MODIFIED state.

In response to this:

Bug 1731191: Flaky htpasswd e2e

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sttts sttts sttts left review comments

@deads2k deads2k deads2k left review comments

@gabemontero gabemontero Awaiting requested review from gabemontero

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@sanchezl sanchezl

@deads2k deads2k

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@sallyom @openshift-ci-robot @tnozicka @stlaz @sanchezl @enj @openshift-bot @sttts @deads2k @openshift-merge-robot