Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dead test code #23477

Merged
merged 3 commits into from
Jul 25, 2019

Conversation

mfojtik
Copy link
Contributor

@mfojtik mfojtik commented Jul 25, 2019

giving @deads2k free test run with examples restored in bindata: #23469

@openshift-ci-robot openshift-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jul 25, 2019
Copy link

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik: 6 invalid OWNERS files

In response to this:

giving @deads2k free test run with examples restored in bindata: #23469

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -1,17 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/test/testdata/OWNERS: no such file or directory.

@@ -1,12 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/test/util/OWNERS: no such file or directory.

@@ -1,18 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/pkg/cmd/OWNERS: no such file or directory.

@@ -1,8 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/test/cmd/OWNERS: no such file or directory.

@@ -1,16 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/test/integration/OWNERS: no such file or directory.

@@ -1,12 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git728879987/test/templates/OWNERS: no such file or directory.

@mfojtik mfojtik force-pushed the mfojtik-remove-test-integration-01 branch from b7b1fbc to 4edae8f Compare July 25, 2019 10:03
Copy link

@openshift-ci-robot openshift-ci-robot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mfojtik: 6 invalid OWNERS files

In response to this:

giving @deads2k free test run with examples restored in bindata: #23469

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@@ -1,18 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/pkg/cmd/OWNERS: no such file or directory.

@@ -1,8 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/test/cmd/OWNERS: no such file or directory.

@@ -1,16 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/test/integration/OWNERS: no such file or directory.

@@ -1,12 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/test/templates/OWNERS: no such file or directory.

@@ -1,17 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/test/testdata/OWNERS: no such file or directory.

@@ -1,12 +0,0 @@
reviewers:

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot parse file: open /tmp/git281492534/test/util/OWNERS: no such file or directory.

@deads2k deads2k removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jul 25, 2019
@deads2k
Copy link
Contributor

deads2k commented Jul 25, 2019

sure

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 25, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mfojtik
Copy link
Contributor Author

mfojtik commented Jul 25, 2019

Button merging this as this is giving us a surface to build next PR's. The PR owners in the batch understand the priority.

@mfojtik mfojtik merged commit 4708895 into openshift:master Jul 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants