Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UPSTREAM: 78222: Fix nil pointer dereference in metrics value calculator #23489

Merged
merged 1 commit into from Aug 1, 2019
Merged

UPSTREAM: 78222: Fix nil pointer dereference in metrics value calculator #23489

merged 1 commit into from Aug 1, 2019

Conversation

humblec
Copy link
Contributor

@humblec humblec commented Jul 26, 2019

Signed-off-by: Humble Chirammal hchiramm@redhat.com

@humblec
UPSTREAM: 78222: Fix nil pointer dereference in metrics value calculator
b298b4b 
Signed-off-by: Humble Chirammal <hchiramm@redhat.com>
@openshift-ci-robot openshift-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jul 26, 2019
@humblec
Copy link
Contributor Author

humblec commented Jul 26, 2019

/assign @gnufied

@humblec
Copy link
Contributor Author

humblec commented Jul 26, 2019

/retest

1 similar comment
@humblec
Copy link
Contributor Author

humblec commented Jul 26, 2019

/retest

@humblec
Copy link
Contributor Author

humblec commented Jul 29, 2019

@gnufied PTAL :)

@gnufied
Copy link
Member

gnufied commented Jul 29, 2019

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2019
@humblec
Copy link
Contributor Author

humblec commented Jul 30, 2019

/assign @eparis

@gnufied
Copy link
Member

gnufied commented Jul 31, 2019

/assign @smarterclayton

@smarterclayton
Copy link
Contributor

/lgtm

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gnufied, humblec, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 31, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 4975e77 into openshift:master Aug 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@gnufied gnufied

@smarterclayton smarterclayton

@eparis eparis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@humblec @gnufied @smarterclayton @openshift-ci-robot @openshift-bot @eparis @openshift-merge-robot