New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests/extented/prometheus: Disable telemetry e2e for remote-write move #23925
tests/extented/prometheus: Disable telemetry e2e for remote-write move #23925
Conversation
/lgtm |
/retest |
/retest |
c315801
to
9daddca
Compare
/lgtm |
/retest |
9daddca
to
254adc6
Compare
openshift/cluster-monitoring-operator#434 is now ready to go, so we can move forward here. /hold cancel |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: brancz, s-urbaniak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@brancz: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
This will be temporarily required in order to switch sending telemetry to Prometheus native remote-write capabilities (openshift/cluster-monitoring-operator#434). We will want to merge this PR and openshift/cluster-monitoring-operator#434 quickly after each other and then enable the here commented out check that verifies, that remote-write successfully sent data instead of the bespoke telemeter client.
Telemetry via remote-write can only be accepted by the v2 receiving infrastructure, so we need to hold off on merging this and openshift/cluster-monitoring-operator#434 until the infrastructure is completely migrated.
@s-urbaniak @paulfantom @lilic @squat @smarterclayton
/hold