Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1753731: add extended build new-app tests back #23957

Merged

Conversation

gabemontero
Copy link
Contributor

Undo #23832 as part of openshift/openshift-controller-manager#34 on path for merging

Getting a few runs in pre-merge to see if we can repro the original flake with any frequency, followed by absence of flakes after openshift/openshift-controller-manager#34 merges

/assign @adambkaplan

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 11, 2019
@gabemontero gabemontero changed the title add extended build new-app tests back Bug 1753731: add extended build new-app tests back Oct 11, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Oct 11, 2019
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1753731, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1753731: add extended build new-app tests back

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 11, 2019
@gabemontero
Copy link
Contributor Author

openshift/openshift-controller-manager#34 has merged, so the current test runs will be the only pre-fix test run we get.

Of course we can re-run tests here prior to merging with the fix as much as we want all the same.

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

passing e2e-aws-build # 1

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-build # 2

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-build # 3

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds # 4

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds # 5

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds # 6

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds # 7

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds # 8

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

passing e2e-aws-builds test # 9

/test e2e-aws-builds

@gabemontero
Copy link
Contributor Author

OK @adambkaplan we have now had 10 straight e2e-aws-builds runs where the oc new-app test enabled here has passed.

Shall we go ahead and merge this?

thanks

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

imo 10/10 means we're not flaky any more.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 14, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

oauth server flake

/test e2e-aws-serial

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit af7ac0b into openshift:master Oct 14, 2019
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1753731 has been moved to the MODIFIED state.

In response to this:

Bug 1753731: add extended build new-app tests back

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the add-new-app-test-back branch October 14, 2019 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants