-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1753731: add extended build new-app tests back #23957
Bug 1753731: add extended build new-app tests back #23957
Conversation
@gabemontero: This pull request references Bugzilla bug 1753731, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift/openshift-controller-manager#34 has merged, so the current test runs will be the only pre-fix test run we get. Of course we can re-run tests here prior to merging with the fix as much as we want all the same. |
/retest |
passing e2e-aws-build # 1 /test e2e-aws-builds |
passing e2e-aws-build # 2 /test e2e-aws-builds |
passing e2e-aws-build # 3 /test e2e-aws-builds |
passing e2e-aws-builds # 4 /test e2e-aws-builds |
passing e2e-aws-builds # 5 /test e2e-aws-builds |
passing e2e-aws-builds # 6 /test e2e-aws-builds |
passing e2e-aws-builds # 7 /test e2e-aws-builds |
passing e2e-aws-builds # 8 /test e2e-aws-builds |
passing e2e-aws-builds test # 9 /test e2e-aws-builds |
OK @adambkaplan we have now had 10 straight e2e-aws-builds runs where the oc new-app test enabled here has passed. Shall we go ahead and merge this? thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
imo 10/10 means we're not flaky any more.
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
oauth server flake /test e2e-aws-serial |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1753731 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Undo #23832 as part of openshift/openshift-controller-manager#34 on path for merging
Getting a few runs in pre-merge to see if we can repro the original flake with any frequency, followed by absence of flakes after openshift/openshift-controller-manager#34 merges
/assign @adambkaplan