Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.2] Bug 1769950: React to openshift/ruby-hello-world update #24109

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #24100

/assign adambkaplan

Update tests to use ruby-25 image.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.2] React to openshift/ruby-hello-world update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Nov 7, 2019
@adambkaplan
Copy link
Contributor

/retitle Bug 1769950: React to openshift/ruby-hello-world update

@openshift-ci-robot openshift-ci-robot changed the title [release-4.2] React to openshift/ruby-hello-world update Bug 1769950: React to openshift/ruby-hello-world update Nov 7, 2019
@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 7, 2019
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1769950, which is invalid:

  • expected dependent Bugzilla bug 1769949 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1769950: React to openshift/ruby-hello-world update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

Patch manager note: this change is required to get tests to pass and does not alter product code.

@adambkaplan adambkaplan changed the title Bug 1769950: React to openshift/ruby-hello-world update [release-3.11] Bug 1769950: React to openshift/ruby-hello-world update Nov 8, 2019
@adambkaplan adambkaplan changed the title [release-3.11] Bug 1769950: React to openshift/ruby-hello-world update [release-4.2] Bug 1769950: React to openshift/ruby-hello-world update Nov 8, 2019
@adambkaplan
Copy link
Contributor

/retest

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 8, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 8, 2019
@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1769950, which is invalid:

  • expected dependent Bugzilla bug 1769949 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Nov 11, 2019
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1769950, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Nov 11, 2019
@gabemontero
Copy link
Contributor

gabemontero commented Nov 11, 2019

ok bugzilla bot happy now ... just need patch manager cherry pick approval

please see @adambkaplan 's #24109 (comment)

@eparis
Copy link
Member

eparis commented Nov 12, 2019

why did the tests stop passing?

@gabemontero
Copy link
Contributor

why did the tests stop passing?

ruby 2.2 went out of service @eparis and became more and more flaky / non-functional, so test repos like https://github.com/openshift/ruby-hello-world were updated (there may have been other test repos ... @adambkaplan can elaborate if I'm missing one)

but as a result, there were tests in openshift/origin, in multiple releases, that needed to be updated because they were trying to use ruby 2.2 via these test repos

@adambkaplan
Copy link
Contributor

@eparis openshift/ruby-hello-world was updated to work on ruby 2.5, vs. 2.2 which has been EOL for quite some time. SCL has https://github.com/sclorg/ruby-ex, which is simpler and has been kept up to date. I believe tests that used this repo were migrated to 2.5 in the 4.2 timeframe.

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1769950 has been moved to the MODIFIED state.

In response to this:

[release-4.2] Bug 1769950: React to openshift/ruby-hello-world update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants