-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-4.2] Bug 1769950: React to openshift/ruby-hello-world update #24109
[release-4.2] Bug 1769950: React to openshift/ruby-hello-world update #24109
Conversation
Update tests to use ruby-25 image.
@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retitle Bug 1769950: React to openshift/ruby-hello-world update |
@openshift-cherrypick-robot: This pull request references Bugzilla bug 1769950, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Patch manager note: this change is required to get tests to pass and does not alter product code. |
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, openshift-cherrypick-robot The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 1769950, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 1769950, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ok bugzilla bot happy now ... just need patch manager cherry pick approval please see @adambkaplan 's #24109 (comment) |
why did the tests stop passing? |
ruby 2.2 went out of service @eparis and became more and more flaky / non-functional, so test repos like https://github.com/openshift/ruby-hello-world were updated (there may have been other test repos ... @adambkaplan can elaborate if I'm missing one) but as a result, there were tests in openshift/origin, in multiple releases, that needed to be updated because they were trying to use ruby 2.2 via these test repos |
@eparis openshift/ruby-hello-world was updated to work on ruby 2.5, vs. 2.2 which has been EOL for quite some time. SCL has https://github.com/sclorg/ruby-ex, which is simpler and has been kept up to date. I believe tests that used this repo were migrated to 2.5 in the 4.2 timeframe. |
@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1769950 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is an automated cherry-pick of #24100
/assign adambkaplan