Rewrite commitchecker so it validates bumps as well #24234
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
Naive question: why do we need a full rewrite? |
Can't say I wasn't expecting that question. The godeps have been pretty bundled to it and all the function were assuming they never get bump commits. |
tnozicka
force-pushed
the
enforce-bumps
branch
4 times, most recently
from
78fcc86
to
ee8636d
Compare
tnozicka
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
/retest |
2 similar comments
|
/retest |
|
/retest |
| var allErrors []string | ||
|
|
||
| if strings.HasPrefix(commit.Email, "root@") { | ||
| allErrors = append(allErrors, fmt.Sprintf("Commit %s has invalid email %q", commit.Sha, commit.Email)) |
There was a problem hiding this comment.
errors may not start with capital letter
tools/rebasehelpers/util/git.go
Outdated
| // patchRegexps holds regexps for paths inside vendor dir that are allowed to be patched directly. | ||
| // It must corresponds to published repositories. | ||
| PatchRegexps = []*regexp.Regexp{ | ||
| regexp.MustCompile("^k8s.io/.*"), |
There was a problem hiding this comment.
actually only k8s.io/kubernetes. Staging dirs also have that prefix. k8s.io/{utils,kube-openapi,gengo,....} must not be patched.
There was a problem hiding this comment.
yeah, looks like we only publish staging dirs, this should match that list
There was a problem hiding this comment.
There was a problem hiding this comment.
Technically not even the staging dirs, but just kube. Your linked commit looks good.
tnozicka
force-pushed
the
enforce-bumps
branch
from
ee8636d
to
80cfb21
Compare
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sttts, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/cherry-pick release-4.3 |
|
@tnozicka: new pull request created: #24261 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cc @sttts @deads2k
@openshift/sig-master