Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1779563: fix oc adm node logs and add tests #24258

Merged
merged 2 commits into from Dec 13, 2019

Conversation

soltysh
Copy link
Member

@soltysh soltysh commented Dec 5, 2019

This should fix it once and for all, and I'm also adding tests. I'll create a followup shortly to add tests for the --since with date parameter, but given there's some time between when this lands in kubelet I'll hold that other PR.
/assign @smarterclayton

@p0lyn0mial fyi, since you're working on the k8s bump

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 5, 2019
@soltysh
Copy link
Member Author

soltysh commented Dec 5, 2019

/cherry-pick release-4.3

@openshift-cherrypick-robot

@soltysh: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 5, 2019
@soltysh
Copy link
Member Author

soltysh commented Dec 5, 2019

/retest

@soltysh
Copy link
Member Author

soltysh commented Dec 5, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

@soltysh: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh changed the title Bug1779563 - fix oc adm node logs and add tests Bug1779563: fix oc adm node logs and add tests Dec 5, 2019
@soltysh soltysh changed the title Bug1779563: fix oc adm node logs and add tests Bug 1779563: fix oc adm node logs and add tests Dec 5, 2019
@openshift-ci-robot
Copy link

@soltysh: This pull request references Bugzilla bug 1779563, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1779563: fix oc adm node logs and add tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Dec 5, 2019
@soltysh
Copy link
Member Author

soltysh commented Dec 5, 2019

/retest

@smarterclayton
Copy link
Contributor

/retest

5 similar comments
@soltysh
Copy link
Member Author

soltysh commented Dec 10, 2019

/retest

@nee1esh
Copy link

nee1esh commented Dec 10, 2019

/retest

@soltysh
Copy link
Member Author

soltysh commented Dec 11, 2019

/retest

@soltysh
Copy link
Member Author

soltysh commented Dec 11, 2019

/retest

@soltysh
Copy link
Member Author

soltysh commented Dec 12, 2019

/retest

@mfojtik
Copy link
Member

mfojtik commented Dec 12, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 12, 2019
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@smarterclayton
Copy link
Contributor

/refresh

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 66d6dd7 into openshift:master Dec 13, 2019
@openshift-ci-robot
Copy link

@soltysh: All pull requests linked via external trackers have merged. Bugzilla bug 1779563 has been moved to the MODIFIED state.

In response to this:

Bug 1779563: fix oc adm node logs and add tests

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@soltysh: new pull request created: #24293

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@soltysh soltysh deleted the bug1779563 branch December 13, 2019 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants