Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

openshift-test: azure don't set the UserAgent to include the current test name when loading cloud provider config #24336

Merged
merged 1 commit into from Dec 21, 2019
Merged

openshift-test: azure don't set the UserAgent to include the current test name when loading cloud provider config #24336

merged 1 commit into from Dec 21, 2019

Conversation

p0lyn0mial
Copy link
Contributor

I hope that this PR will fix the following panic observed in e2e-azure-upgrade

panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x80 pc=0x127b1c6]

goroutine 1 [running]:
github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/specrunner.(*SpecRunner).CurrentSpecSummary(...)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/specrunner/spec_runner.go:211
github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/suite.(*Suite).CurrentRunningSpecSummary(0xc000283400, 0x121a, 0x121b)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/internal/suite/suite.go:105 +0x26
github.com/openshift/origin/vendor/github.com/onsi/ginkgo.CurrentGinkgoTestDescription(0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, 0x0, ...)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/onsi/ginkgo/ginkgo_dsl.go:159 +0x70
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework.LoadConfig.func1(0xc0014e3198, 0xc0014e3190, 0x0, 0x0, 0x0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:573 +0x70
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework.LoadConfig(0x0, 0x0, 0x0, 0xc002356600, 0x0, 0x0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:593 +0x34f
github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework.LoadClientset(0x0, 0x0, 0x0, 0x0, 0x0, 0x6000105)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/k8s.io/kubernetes/test/e2e/framework/util.go:598 +0x43
github.com/openshift/origin/test/extended/util/azure.LoadConfigFile(0xc0014e3340, 0xc004441b30, 0x3, 0x3, 0x0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/azure/config_file.go:20 +0x36
github.com/openshift/origin/test/extended/util/cloud.LoadConfig(0x5fb5ac0, 0xc003475590, 0x5fb5b00, 0xc0034755a0, 0x5fb5a40)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/test/extended/util/cloud/cloud.go:90 +0x625
main.decodeProviderTo(0x7ffd3e3a4933, 0x5, 0x9596520, 0x0, 0x1, 0x91e3c60)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:314 +0x76
main.initProvider(0x7ffd3e3a4933, 0x5, 0x0, 0x0, 0xc001c2a9c0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:280 +0x4e
main.newRunUpgradeCommand.func1.1(0xc0014e3b98, 0x2)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:189 +0x204
main.mirrorToFile(0xc00146c3c0, 0xc0014e3be8, 0x4, 0x5466732)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:255 +0x244
main.newRunUpgradeCommand.func1(0xc001c18a00, 0xc002535b00, 0x1, 0x9, 0x0, 0x0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:169 +0x82
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).execute(0xc001c18a00, 0xc002535a70, 0x9, 0x9, 0xc001c18a00, 0xc002535a70)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:826 +0x460
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).ExecuteC(0xc001c18500, 0x0, 0x5ecf860, 0x95b3308)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:914 +0x2fb
github.com/openshift/origin/vendor/github.com/spf13/cobra.(*Command).Execute(...)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/vendor/github.com/spf13/cobra/command.go:864
main.main.func1(0xc001c18500, 0x0, 0x0)
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:68 +0x9c
main.main()
	/go/src/github.com/openshift/origin/_output/local/go/src/github.com/openshift/origin/cmd/openshift-tests/openshift-tests.go:69 +0x341

@p0lyn0mial
openshift-test: azure don't set the UserAgent to include the current …
01fa002 
…test name when loading cloud provider config
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Dec 20, 2019
@p0lyn0mial
Copy link
Contributor Author

/retest

@mfojtik
Copy link
Member

mfojtik commented Dec 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Dec 20, 2019
soltysh
soltysh approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@mfojtik
Copy link
Member

mfojtik commented Dec 20, 2019

/approve

@p0lyn0mial p0lyn0mial mentioned this pull request Dec 20, 2019
Merged
11 tasks
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mfojtik, p0lyn0mial, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Dec 20, 2019
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

7 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 8a9ae19 into openshift:master Dec 21, 2019
@p0lyn0mial p0lyn0mial mentioned this pull request Dec 23, 2019
Merged
@smarterclayton
Copy link
Contributor

We have to fix upstream, there are places where you want to call test utility before ginkgo starts. The client utility code should be checking for nil instead of panicking.

@p0lyn0mial
Copy link
Contributor Author

We have to fix upstream, there are places where you want to call test utility before ginkgo starts.

I haven't found places like that. All traces lead to indirect or direct usage.

Nevertheless, I am happy to take it upstream if you tag it.

@hexfusion
Copy link
Contributor

thanks @p0lyn0mial

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@soltysh soltysh soltysh approved these changes

@gabemontero gabemontero Awaiting requested review from gabemontero

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@mfojtik mfojtik

@soltysh soltysh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@p0lyn0mial @mfojtik @openshift-ci-robot @openshift-bot @smarterclayton @hexfusion @soltysh @openshift-merge-robot