bug 1797740: UPSTREAM: <carry>: simplify the authorizer patch to allow the flags t… #24435
Conversation
openshift-ci-robot
added
size/M
|
/retest |
|
terraform /retest |
|
/retest |
| @@ -4,6 +4,8 @@ import ( | |||
| "io/ioutil" | |||
| "path" | |||
|
|
|||
| "k8s.io/apiserver/pkg/server" | |||
|
|
|||
| package modes | ||
|
|
||
| var ModeScope = "Scope" | ||
| var ModeSystemMasters = "SystemMasters" |
There was a problem hiding this comment.
why not also BrowserSafe?
Because that change the resources, but the point of SystemMasters is to approve everything, no matter the resource.
There was a problem hiding this comment.
as another authz-mode? Which resource?
There was a problem hiding this comment.
as another authz-mode? Which resource?
it wraps the attributes with an adapter than can conditionally return a different verb and resource for /proxy to require a second rule to allow it so that always comes from an authenticated request.
|
|
||
| var skipSystemMastersAuthorizer = false | ||
|
|
||
| func SkipSystemMastersAuthorizer() { |
vendor/k8s.io/kubernetes/openshift-kube-apiserver/enablement/intialization.go
Show resolved
Hide resolved
deads2k
force-pushed
the
simplify-authorizer-patch
branch
from
ce2c35b
to
0d7fb2d
Compare
openshift-ci-robot
added
size/L
|
/lgtm Out of curiosity: https://github.com/openshift/origin/pull/24435/files#r370282776 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
11 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
deads2k
changed the title
|
@deads2k: This pull request references Bugzilla bug 1797740, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@deads2k: All pull requests linked via external trackers have merged. Bugzilla bug 1797740 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
…o function