Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1791200: test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking #24465

Merged
merged 1 commit into from
Feb 5, 2020
Merged

Bug 1791200: test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking #24465

merged 1 commit into from
Feb 5, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #24276

/assign paulfantom

@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.3] test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Jan 28, 2020
Merged
@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 28, 2020
@paulfantom
Copy link
Contributor

/retitle Bug 1791200: test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking Bug 1791200: test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking Jan 28, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Jan 28, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1791200, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

Bug 1791200: test/extended/prometheus: exclude AlertmanagerReceiversNotConfigured from checking

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor

paulfantom commented Jan 28, 2020 •
edited
Loading

This is necessary to merge openshift/cluster-monitoring-operator#613

@paulfantom
Copy link
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 28, 2020
@paulfantom
Copy link
Contributor

/retest

@paulfantom
Copy link
Contributor

/cc @openshift/openshift-team-monitoring

simonpasquier
simonpasquier reviewed Jan 28, 2020
View reviewed changes
Copy link
Contributor

@simonpasquier simonpasquier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 28, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, paulfantom, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis eparis added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Feb 4, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 39969e9 into openshift:release-4.3 Feb 5, 2020
@paulfantom paulfantom mentioned this pull request Mar 5, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonpasquier simonpasquier simonpasquier left review comments

@metalmatze metalmatze Awaiting requested review from metalmatze

@paulfantom paulfantom Awaiting requested review from paulfantom

Assignees

@simonpasquier simonpasquier

@paulfantom paulfantom

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@openshift-cherrypick-robot @openshift-ci-robot @paulfantom @openshift-bot @simonpasquier @eparis @openshift-merge-robot