Bug 1794885: UPSTREAM: <carry>: bootstrap user - make tokens have implicit audiences #24503
Conversation
openshift-ci-robot
added
the
size/M
stlaz
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@stlaz: This pull request references Bugzilla bug 1794885, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: stlaz, sttts The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
It's actually copied from upstream (service account authn). If we want to factor it out, then in upstream. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
In an ideal world, yes, the openshift patches for tokenauthenticator and bootstrapauthenticator would derive from better-factored upstream code. I'm not sure why it would be necessary to wait for that, though, to remove the potential source of errors represented by tokenauthenticator and bootstrapauthenticator being independently implemented given that their functionality is largely common. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test all |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@stlaz: All pull requests linked via external trackers have merged. Bugzilla bug 1794885 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
cc @sttts @marun