Bug 1806698: Limit-based eviction should report metrics #24595
Conversation
Limit-based eviction has the same outcome as a capacity-based eviction but was not being reported to the kubelet_evictions metric, which makes it harder to alert on. Report those evictions to the metric with appropriate signals.
openshift-ci-robot
added
size/S
smarterclayton
changed the title
openshift-ci-robot
added
the
bugzilla/valid-bug
|
@smarterclayton: This pull request references Bugzilla bug 1806698, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.4 |
|
@smarterclayton: once the present PR merges, I will cherry-pick it on top of release-4.4 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
4.4 is bug 1806699 |
|
/assign @rphillips |
|
/retest |
|
/test e2e-aws-serial |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rphillips, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/test e2e-aws-serial |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
7 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1806698 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@smarterclayton: new pull request created: #24603 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Limit-based eviction has the same outcome as a capacity-based eviction
but was not being reported to the kubelet_evictions metric, which makes
it harder to alert on. Report those evictions to the metric with
appropriate signals.