Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Standardize disruption reporting #24600

Merged
merged 1 commit into from Feb 26, 2020
Merged

test: Standardize disruption reporting #24600

merged 1 commit into from Feb 26, 2020

Conversation

smarterclayton
Copy link
Contributor

The error message should include the total duration and the % impacted.
Use a shared method to report that to simplify future changes.

Update the allowed disruption percent for frontends to 20%.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 25, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 25, 2020
@smarterclayton
test: Standardize disruption reporting
f6438dc 
The error message should include the total duration and the % impacted.
Use a shared method to report that to simplify future changes.

Update the allowed disruption percent for frontends to 20%.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Feb 26, 2020
@smarterclayton smarterclayton merged commit 768ae70 into openshift:master Feb 26, 2020
@openshift-ci-robot
Copy link

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-cmd f6438dc link /test e2e-cmd
ci/prow/e2e-gcp-upgrade f6438dc link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gabemontero gabemontero Awaiting requested review from gabemontero

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smarterclayton @openshift-ci-robot