Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Update the ginkgo annotator to avoid double naming #24682

Merged
merged 2 commits into from Mar 16, 2020
Merged

test: Update the ginkgo annotator to avoid double naming #24682

merged 2 commits into from Mar 16, 2020

Conversation

smarterclayton
Copy link
Contributor

We were including [Top Level] and the parent nodes twice in output, which
made all test names substantially longer. Pick up the improved ginkgo
interface and keep the parent node name separate.

Before:

[Feature:UserAPI] [Top Level] [Feature:UserAPI] users can manipulate groups [Suite:openshift/conformance/parallel]

After:

[Feature:UserAPI] users can manipulate groups [Suite:openshift/conformance/parallel]

@openshift-ci-robot openshift-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Mar 12, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 12, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Mar 12, 2020
@smarterclayton smarterclayton force-pushed the simplify_names branch 2 times, most recently from c39a013 to 426289e Compare March 13, 2020 00:31
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/test images

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/retest

1 similar comment
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton smarterclayton force-pushed the simplify_names branch 2 times, most recently from b229678 to 5f5e6e5 Compare March 14, 2020 03:50
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/test e2e-gcp-upgrade

1 similar comment
@smarterclayton
Copy link
Contributor Author

/test e2e-gcp-upgrade

@smarterclayton
bump: Update dependencies to pick up newer ginkgo carry
c974280 
Gingko was updated to origin-4.5 to contain an improved method for
simplifying dependencies.
@smarterclayton
test: Update the ginkgo annotator to avoid double naming
b5146f4 
We were including `[Top Level]` and the parent nodes twice in output,
which made all test names substantially longer. Pick up the improved
ginkgo interface and keep the parent node name separate.

Before:

> [Feature:UserAPI] [Top Level] [Feature:UserAPI] users can manipulate groups [Suite:openshift/conformance/parallel]

After:

> [Feature:UserAPI] users can manipulate groups [Suite:openshift/conformance/parallel]
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 16, 2020
@smarterclayton
Copy link
Contributor Author

Rebased and reapplied label. Failures are not specific to this Pr

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 16, 2020 •
edited

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-image-registry 5f5e6e5 link /test e2e-aws-image-registry

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6741349 into openshift:master Mar 16, 2020
@wking wking mentioned this pull request Mar 16, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bparees bparees Awaiting requested review from bparees

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@smarterclayton @openshift-ci-robot @openshift-bot @openshift-merge-robot