Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1806407: Add a delay between successive retries for service reachability check and wait for n consecutive successes. #24684

Merged
merged 2 commits into from Mar 20, 2020
Merged

Bug 1806407: Add a delay between successive retries for service reachability check and wait for n consecutive successes. #24684

merged 2 commits into from Mar 20, 2020

Conversation

openshift-cherrypick-robot
Copy link

This is an automated cherry-pick of #24632

/assign smarterclayton

@abhat
Add a delay between successive retries for service reachability check
c3c114f
@abhat
Add a mechanism to retry for n consecutive reachability successes
766bcfd 
Hoisted the function that checks for http reachability to the e2e
test and modified it's logic to retry till we have n consecutive
reachability successes. If there is a single failure, the counter
is reset.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 13, 2020
Merged
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

[release-4.4] test: Add a delay between successive retries for service reachability check and wait for n consecutive successes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 13, 2020
@smarterclayton smarterclayton changed the title [release-4.4] test: Add a delay between successive retries for service reachability check and wait for n consecutive successes. Bug 1806407: Add a delay between successive retries for service reachability check and wait for n consecutive successes. Mar 17, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1806407, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is ON_QA instead
  • expected dependent Bugzilla bug 1806406 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1806407: Add a delay between successive retries for service reachability check and wait for n consecutive successes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2020
@smarterclayton
Copy link
Contributor

This needs to be in 4.4 so that e2e aws upgrade tests properly report Service downtime (the AWS LB was reporting success briefly when created, but then failed after). This is the last test related change to backport to 4.4.

@smarterclayton
Copy link
Contributor

/retest

@smarterclayton smarterclayton added approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 19, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 7a96559 into openshift:release-4.4 Mar 20, 2020
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1806407 is in an unrecognized state (ON_QA) and will not be moved to the MODIFIED state.

In response to this:

Bug 1806407: Add a delay between successive retries for service reachability check and wait for n consecutive successes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrogers950 mrogers950 Awaiting requested review from mrogers950

@soltysh soltysh Awaiting requested review from soltysh

Assignees

@smarterclayton smarterclayton

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@openshift-cherrypick-robot @openshift-ci-robot @smarterclayton @openshift-bot @openshift-merge-robot @abhat