Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix a few remaining issues from the test renaming #24692

Merged
merged 2 commits into from Mar 15, 2020

Conversation

smarterclayton
Copy link
Contributor

Fix excludes on sig-scalability and sig-cluster-lifecycle. Remove
use of [Conformance] in openshift tests. Rename [local] to [Local].

Fix excludes on sig-scalability and sig-cluster-lifecycle. Remove
use of [Conformance] in openshift tests. Rename [local] to [Local].
@smarterclayton smarterclayton added approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. labels Mar 13, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@bparees
Copy link
Contributor

bparees commented Mar 13, 2020

this is gonna merge conflict with #24687

can you cherrypick my changes into this PR?

@smarterclayton
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

[sig-imageregistry][Feature:ImageTriggers][Serial] ImageStream API [Top Level] [sig-imageregistry][Feature:ImageTriggers][Serial] ImageStream API TestImageStreamMappingCreate [Suite:openshift/conformance/serial] expand_less	4s
fail [github.com/openshift/origin/test/extended/images/imagestream.go:85]: Unexpected error:
    <*errors.StatusError | 0xc00214a280>: {
        ErrStatus: {
            TypeMeta: {Kind: "", APIVersion: ""},
            ListMeta: {
                SelfLink: "",
                ResourceVersion: "",
                Continue: "",
                RemainingItemCount: nil,
            },
            Status: "Failure",
            Message: "images.image.openshift.io \"image2\" already exists",
            Reason: "AlreadyExists",
            Details: {
                Name: "image2",
                Group: "image.openshift.io",
                Kind: "images",
                UID: "",
                Causes: nil,
                RetryAfterSeconds: 0,
            },
            Code: 409,
        },
    }
    images.image.openshift.io "image2" already exists

Looks broken, may have been taken off the skip list by my recent changes (but not in this PR)

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Mar 14, 2020

as March 10th the job was only running 35 tests:

https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24574/pull-ci-openshift-origin-master-e2e-aws-image-registry/1089

and that wasn't one of them.

Now it's running 57:
https://prow.svc.ci.openshift.org/view/gcs/origin-ci-test/pr-logs/pull/24692/pull-ci-openshift-origin-master-e2e-aws-image-registry/1112

so yeah, something about the recent change affected what's being picked up.

But we should also check with @dmage about why so many tests are disabled... I suspect it's integration tests that we haven't gotten re-enabled yet after the conversion to e2e, but we should confirm they're being tracked for re-enablement.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton
Copy link
Contributor Author

Most of the new tests are things like the image cli tests. They belong to sig-image registry, but they are run in the CLI suite. We may just want to make the image registry suite be based on a set of "[Feature:Image...]" tags rather than on [sig-image-registry].

@smarterclayton
Copy link
Contributor Author

The test is wrong, it assumes no retries or other executions. I need to fix it.

The test was not designed to be run in parallel, should use a random
name.
@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2020
@smarterclayton
Copy link
Contributor Author

I pushed a fix, hopefully should clear it. Whichever of us wins will have to rebase.

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2020
@bparees
Copy link
Contributor

bparees commented Mar 14, 2020

I pushed a fix, hopefully should clear it. Whichever of us wins will have to rebase.

loses.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 193edda into openshift:master Mar 15, 2020
@openshift-ci-robot
Copy link

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-aws-fips 28939df link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants