New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: Fix a few remaining issues from the test renaming #24692
test: Fix a few remaining issues from the test renaming #24692
Conversation
Fix excludes on sig-scalability and sig-cluster-lifecycle. Remove use of [Conformance] in openshift tests. Rename [local] to [Local].
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
this is gonna merge conflict with #24687 can you cherrypick my changes into this PR? |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
Looks broken, may have been taken off the skip list by my recent changes (but not in this PR) |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
as March 10th the job was only running 35 tests: and that wasn't one of them. Now it's running 57: so yeah, something about the recent change affected what's being picked up. But we should also check with @dmage about why so many tests are disabled... I suspect it's integration tests that we haven't gotten re-enabled yet after the conversion to e2e, but we should confirm they're being tracked for re-enablement. |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
Most of the new tests are things like the image cli tests. They belong to sig-image registry, but they are run in the CLI suite. We may just want to make the image registry suite be based on a set of "[Feature:Image...]" tags rather than on [sig-image-registry]. |
The test is wrong, it assumes no retries or other executions. I need to fix it. |
The test was not designed to be run in parallel, should use a random name.
New changes are detected. LGTM label has been removed. |
I pushed a fix, hopefully should clear it. Whichever of us wins will have to rebase. |
loses. |
/retest Please review the full test history for this PR and help us cut down flakes. |
4 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
/retest Please review the full test history for this PR and help us cut down flakes. |
@smarterclayton: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
Fix excludes on sig-scalability and sig-cluster-lifecycle. Remove
use of [Conformance] in openshift tests. Rename [local] to [Local].