Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1809862: log snippet test; failed git clone within init container #24727

Merged

Conversation

gabemontero
Copy link
Contributor

this new test should only pass once openshift/openshift-controller-manager#77 merges

/assign @bparees

@openshift/openshift-team-developer-experience FYI

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 19, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1809862, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1809862: log snippet test; failed git clone within init container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 19, 2020
@bparees
Copy link
Contributor

bparees commented Mar 19, 2020

/lgtm
/hold

@gabemontero please do make sure the test doesn't pass w/o your PR changes being merged, but i agree it shouldn't (logsnippet should be empty w/o your PR)

@openshift-ci-robot openshift-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. labels Mar 19, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gabemontero
Copy link
Contributor Author

our new test failed as expected @bparees


[sig-builds][Feature:Builds][Slow]  update failure status  Build status Docker fetch source failure should  contain the Docker build fetch source failure reason and message  [Suite:openshift] expand_less | 46s
-- | --
fail [github.com/openshift/origin/test/extended/builds/failure_status.go:118]: Should not get an error or timeout getting LogSnippet Unexpected error:     <*errors.errorString \| 0xc0002b31b0>: {         s: "timed out waiting for the condition",     }     timed out waiting for the condition occurred

the other tests in that file passed

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

passing e2e-gcp-builds

/hold cancel

/retest

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 21, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

4 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d01a5df into openshift:master Mar 22, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged. Bugzilla bug 1809862 has been moved to the MODIFIED state.

In response to this:

Bug 1809862: log snippet test; failed git clone within init container

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the badgitclone-log-snippet branch March 22, 2020 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants