test: Skip unpacking file contents except when the test is actually running #24739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
smarterclayton
force-pushed
the
optimize_start
branch
10 times, most recently
from
447a387
to
aeb5467
Compare
|
/test e2e-aws-serial |
|
/retest |
1 similar comment
|
/retest |
smarterclayton
force-pushed
the
optimize_start
branch
from
aeb5467
to
5c89a37
Compare
|
/test all |
smarterclayton
force-pushed
the
optimize_start
branch
from
5c89a37
to
c5c4d02
Compare
|
/retest |
1 similar comment
|
/retest |
smarterclayton
force-pushed
the
optimize_start
branch
from
c5c4d02
to
a2c5fc2
Compare
|
/retest |
smarterclayton
force-pushed
the
optimize_start
branch
from
a2c5fc2
to
fa16538
Compare
|
/retest |
…unning In general test startup should do a minimal amount of static work before the test suite runs. Set up guard rails within exutil that prevent tests from running commands. Standardize the setup of the test process now that key methods on the kube Framework are public. Standardize how exutil is included and called in all packages. The command test is switched to asking for a list of filenames from the fixtures. The multicast test no longer instantiates a framework outside of a block. Ensure that fixtures are cleaned up after the test exits instead of being left around.
smarterclayton
force-pushed
the
optimize_start
branch
from
fa16538
to
e17e8f2
Compare
|
/retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid a large amount of disk copies for no purpose. Ginkgo calls the top
level functions twice (once to get test names, then once for execution).
The command test is switched to asking for a list of filenames from the
fixtures. The multicast test no longer instantiates a framework outside
of a block. Ensure that fixtures are cleaned up after the test exits
instead of being left around.