Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1815944: Pick up Ginkgo test performance fix to reduce e2e CPU usage #24746

Merged
merged 1 commit into from Mar 25, 2020
Merged

Bug 1815944: Pick up Ginkgo test performance fix to reduce e2e CPU usage #24746

merged 1 commit into from Mar 25, 2020

Conversation

smarterclayton
Copy link
Contributor

Picks up a fix to Ginkgo that substantially reduces amount of CPU used
in our CI infrastructure to run e2e tests.

@smarterclayton
vendor: Update vendored dependencies to the latest
afd817d 
Picks up a fix to Ginkgo that substantially reduces amount of CPU used
in our CI infrastructure to run e2e tests.
@openshift-ci-robot
Copy link

@smarterclayton: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

vendor: Update vendored dependencies to the latest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 22, 2020
@smarterclayton smarterclayton changed the title vendor: Update vendored dependencies to the latest Bug 1815944: Pick up Ginkgo test performance fix to reduce e2e CPU usage Mar 22, 2020
@openshift-ci-robot
Copy link

@smarterclayton: This pull request references Bugzilla bug 1815944, which is invalid:

  • expected dependent Bugzilla bug 1815941 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1815944: Pick up Ginkgo test performance fix to reduce e2e CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 22, 2020
@smarterclayton smarterclayton added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 22, 2020
@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton
Copy link
Contributor Author

/retest

Not sure if it is reliable

@smarterclayton
Copy link
Contributor Author

/retest

@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2020
@mrunalp mrunalp added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 25, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 6659c8c into openshift:release-4.3 Mar 25, 2020
@openshift-ci-robot
Copy link

@smarterclayton: All pull requests linked via external trackers have merged. Bugzilla bug 1815944 has been moved to the MODIFIED state.

In response to this:

Bug 1815944: Pick up Ginkgo test performance fix to reduce e2e CPU usage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjenning sjenning Awaiting requested review from sjenning

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@smarterclayton @openshift-ci-robot @openshift-bot @mrunalp @openshift-merge-robot