Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages #24819

Merged
merged 1 commit into from Apr 21, 2020
Merged

Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages #24819

merged 1 commit into from Apr 21, 2020

Conversation

huffmanca
Copy link
Contributor

What type of PR is this?
/kind bug

What this PR does / why we need it:
When making modifications to an immutable field we don't print the field that's attempted to be edited, only the included message. This PR makes the messages more user-friendly.

Which issue(s) this PR fixes:
Bug 1740604

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Apr 2, 2020
@openshift-ci-robot openshift-ci-robot added the vendor-update Touching vendor dir or related files label Apr 2, 2020
@jsafrane
Copy link
Contributor

jsafrane commented Apr 3, 2020

/retitle Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages

@jsafrane
Copy link
Contributor

jsafrane commented Apr 3, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

@jsafrane: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title Bug1740604: UPSTREAM 89300: Expand the PVC validation messages Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages Apr 3, 2020
@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Apr 3, 2020
@openshift-ci-robot
Copy link

@huffmanca: This pull request references Bugzilla bug 1740604, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@jsafrane
Copy link
Contributor

jsafrane commented Apr 3, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 3, 2020
@knobunc
Copy link
Contributor

knobunc commented Apr 16, 2020

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 16, 2020
@huffmanca
Copy link
Contributor Author

/test e2e-gcp-upgrade

@huffmanca
Copy link
Contributor Author

/test e2e-cmd

@huffmanca
Copy link
Contributor Author

/test ci/prow/e2e-gcp

@openshift-ci-robot
Copy link

@huffmanca: The specified target(s) for /test were not found.
The following commands are available to trigger jobs:

  • /test artifacts
  • /test e2e-aws
  • /test e2e-aws-csi
  • /test e2e-aws-disruptive
  • /test e2e-aws-fips
  • /test e2e-aws-image-registry
  • /test e2e-aws-jenkins
  • /test e2e-aws-multitenant
  • /test e2e-aws-ovn
  • /test e2e-aws-serial
  • /test e2e-azure
  • /test e2e-cmd
  • /test e2e-conformance-k8s
  • /test e2e-gcp
  • /test e2e-gcp-builds
  • /test e2e-gcp-image-ecosystem
  • /test e2e-gcp-upgrade
  • /test e2e-vsphere
  • /test images
  • /test launch-vsphere
  • /test unit
  • /test verify
  • /test extended_gssapi
  • /test extended_ldap_groups
  • /test extended_networking

Use /test all to run all jobs.

In response to this:

/test ci/prow/e2e-gcp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@huffmanca
Copy link
Contributor Author

/retest

3 similar comments
@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@huffmanca
Copy link
Contributor Author

/retest

3 similar comments
@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@huffmanca
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

20 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton removed the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@smarterclayton
Copy link
Contributor

Retag once master is merging - retries not helping

@jsafrane
Copy link
Contributor

/lgtm
aws-serial is green

@jsafrane
Copy link
Contributor

/retest

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 21, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: huffmanca, jsafrane, knobunc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@huffmanca
Copy link
Contributor Author

/retest

@openshift-merge-robot openshift-merge-robot merged commit 298daf9 into openshift:master Apr 21, 2020
@openshift-ci-robot
Copy link

@huffmanca: All pull requests linked via external trackers have merged: openshift/origin#24819. Bugzilla bug 1740604 has been moved to the MODIFIED state.

In response to this:

Bug 1740604: UPSTREAM 89300: Expand the PVC validation messages

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@tbielawa tbielawa Awaiting requested review from tbielawa

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. vendor-update Touching vendor dir or related files
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@huffmanca @jsafrane @openshift-ci-robot @knobunc @openshift-bot @smarterclayton @openshift-merge-robot