Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Capture e2e events in monitor #24830

Merged
merged 1 commit into from Apr 7, 2020

Conversation

smarterclayton
Copy link
Contributor

@smarterclayton smarterclayton commented Apr 3, 2020

This data is just too valuable.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 3, 2020
@smarterclayton smarterclayton force-pushed the e2e_test branch 2 times, most recently from aa7746b to cee2824 Compare April 6, 2020 00:21
@smarterclayton smarterclayton changed the title DO NOT MERGE: Capture e2e events in monitor Capture e2e events in monitor Apr 6, 2020
Results in a 4x increase in e2e.log size which may impact search
and readability, but the event log is so valuable that we probably
want it for search. Also includes all pods.

Fix the Pulled/Pulling messages to extract the image.

Fix the Restart message to only fire when restart count is not
resetting to zero.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@smarterclayton: The following tests failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp 9f5344f link /test e2e-gcp
ci/prow/e2e-gcp-upgrade 9f5344f link /test e2e-gcp-upgrade
ci/prow/e2e-aws-fips 9f5344f link /test e2e-aws-fips

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@smarterclayton smarterclayton merged commit 21636e6 into openshift:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants