Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Enable a range of tests that are allegedly fixed #24835

Merged
merged 1 commit into from Apr 7, 2020

Conversation

smarterclayton
Copy link
Contributor

Some of the referenced bugs were closed months ago with "can not
reproduce" which is clearly wrong, because the tests were disabled.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2020
Some of the referenced bugs were closed months ago with "can not
reproduce" which is clearly wrong, because the tests were disabled.
@smarterclayton smarterclayton added the lgtm Indicates that a PR is ready to be merged. label Apr 6, 2020
@smarterclayton
Copy link
Contributor Author

@adambkaplan reenabling the resource quota test

@adambkaplan
Copy link
Contributor

@smarterclayton I have a separate PR up to restore the quota test. It's linked to the appropriate BZ.

#24816

@smarterclayton
Copy link
Contributor Author

Close it in favor of this, because I'm reenabling a bunch more and it's already passed.

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci-robot
Copy link

@smarterclayton: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
ci/prow/e2e-gcp-upgrade 5f52d7e link /test e2e-gcp-upgrade

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@smarterclayton smarterclayton merged commit f67629a into openshift:master Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants