clarify test failure message

[bparees]

No description provided.

[bparees]

/assign @adambkaplan

[bparees]

/retest

[adambkaplan]

/hold

The tests are ultimately flaking due to https://bugzilla.redhat.com/show_bug.cgi?id=1823949. Based on the current thread this fix won't land in the immediate future. IMO the test should only check that the leader has the internal registry hostname - we don't need to wait for everything to be rolled out.

[bparees]

Based on the current thread this fix won't land in the immediate future.

it better land in the immediate future, it's a major product bug. We can't ship 4.4 w/ it. And we can't tolerate it in 4.5 for any length of time.

IMO the test should only check that the leader has the internal registry hostname - we don't need to wait for everything to be rolled out.

while it could do that, there is no reason under normal circumstances that the daemonset should not be successfully rolled out. Since we didn't seem to catch this elsewhere, if we're going to drop that check here, we need to ensure there is a test somewhere else that would catch cases like this. Personally i'd just leave it as is.

[adambkaplan]

/hold cancel

/lgtm

I'm convinced we can leave as is - re-reading the thread, fixes are expected this week and this is considered an urgent blocker.

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• test/extended/OWNERS [adambkaplan,bparees]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.

[openshift-bot]

/retest

Please review the full test history for this PR and help us cut down flakes.