New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1822286: Serializes k8s IngressClass test #24927
Bug 1822286: Serializes k8s IngressClass test #24927
Conversation
/assign @knobunc |
test/extended/router/router.go
Outdated
@@ -67,7 +67,7 @@ var _ = g.Describe("[sig-network][Feature:Router]", func() { | |||
) | |||
}) | |||
|
|||
g.It("should serve routes that were created from an ingress", func() { | |||
g.It("should serve routes that were created from an ingress [Serial]", func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to serialize the IngressClass one. This test is quite happy to work in parallel. The IngerssClass one is the one that breaks clusters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@smarterclayton commit 046d3e5
serializes the correct k8s test.
cee6a68
to
046d3e5
Compare
/retitle Bug 1822286: Serializes k8s IngressClass test |
@danehans: This pull request references Bugzilla bug 1822286, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/lgtm |
/test images |
/test e2e-aws-serial
/test e2e-gcp |
aws-serial failed due to:
/test e2e-aws-seria e2e-gcp failed due to:
/test e2e-gcp |
Same aws-serial CI job failure symptom. /test e2e-aws-serial |
Same e2e-gcp job error as #24927 (comment). |
1 similar comment
Same e2e-gcp job error as #24927 (comment). |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danehans, Miciah, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
@danehans: All pull requests linked via external trackers have merged: openshift/origin#24927. Bugzilla bug 1822286 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: CryptoGodfatherVA, danehans, Miciah, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
The test is disrupting other workloads:
/assign @smarterclayton @ironcladlou