Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1822286: Serializes k8s IngressClass test #24927

Merged
merged 1 commit into from Apr 30, 2020
Merged

Bug 1822286: Serializes k8s IngressClass test #24927

merged 1 commit into from Apr 30, 2020

Conversation

danehans
Copy link
Contributor

The test is disrupting other workloads:

/test/extended/testdata/router/ingress.yaml",
        StdErr: "secret/ingress-endpoint-secret created\nservice/ingress-endpoint-1 created\nservice/ingress-endpoint-2 created\npod/ingress-endpoint-1 created\npod/ingress-endpoint-2 created\nError from server (Forbidden): ingresses.networking.k8s.io \"test\" is forbidden: Internal error occurred: 2 default IngressClasses were found, only 1 allowed",
        ExitError: {

/assign @smarterclayton @ironcladlou

@danehans
Copy link
Contributor Author

/assign @knobunc

smarterclayton
smarterclayton reviewed Apr 28, 2020
View reviewed changes
test/extended/router/router.go Outdated
@@ -67,7 +67,7 @@ var _ = g.Describe("[sig-network][Feature:Router]", func() {
)
})

g.It("should serve routes that were created from an ingress", func() {
g.It("should serve routes that were created from an ingress [Serial]", func() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to serialize the IngressClass one. This test is quite happy to work in parallel. The IngerssClass one is the one that breaks clusters.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@smarterclayton commit 046d3e5 serializes the correct k8s test.

@danehans
Copy link
Contributor Author

/retitle Bug 1822286: Serializes k8s IngressClass test

@openshift-ci-robot openshift-ci-robot changed the title Serializes route-to-ingress test suite Bug 1822286: Serializes k8s IngressClass test Apr 28, 2020
@openshift-ci-robot openshift-ci-robot added bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Apr 28, 2020
@openshift-ci-robot
Copy link

@danehans: This pull request references Bugzilla bug 1822286, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1822286: Serializes k8s IngressClass test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Miciah
Copy link
Contributor

Miciah commented Apr 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2020
@danehans
Copy link
Contributor Author

ci/prow/images failed due to:

error: could not run steps: step bin-cross failed: could not wait for build: the build bin-cross failed after 1m25s with reason DockerBuildFailed: Dockerfile build strategy has failed.

/test images

@danehans
Copy link
Contributor Author

e2e-aws-serial failed due to:

Apr 28 21:14:52.966 E ns/openshift-monitoring pod/prometheus-k8s-1 node/ip-10-0-156-119.ec2.internal container/prometheus-config-reloader container exited with code 2 (Error): ts=2020-04-28T21:14:19.169366469Z caller=main.go:85 msg="Starting prometheus-config-reloader version '1.12.16'."\nlevel=error ts=2020-04-28T21:14:19.170966407Z caller=runutil.go:98 msg="function failed. Retrying in next tick" err="trigger reload: reload request failed: Post http://localhost:9090/-/reload: dial tcp [::1]:9090: connect: connection refused"\nlevel=info ts=2020-04-28T21:14:24.266885632Z caller=reloader.go:289 msg="Prometheus reload triggered" cfg_in=/etc/prometheus/config/prometheus.yaml.gz cfg_out=/etc/prometheus/config_out/prometheus.env.yaml rule_dirs=\nlevel=info ts=2020-04-28T21:14:24.267457136Z caller=reloader.go:157 msg="started watching config file and non-recursively rule dirs for changes" cfg=/etc/prometheus/config/prometheus.yaml.gz out=/etc/prometheus/config_out/prometheus.env.yaml dirs=\n

/test e2e-aws-serial

e2e-gcp failed due to:

ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []

/test e2e-gcp

@danehans
Copy link
Contributor Author

aws-serial failed due to:

Apr 29 01:22:26.609 W ns/e2e-persistent-local-volumes-test-9349 pod/security-context-2a5a5079-50fe-4240-936e-76df5f7617db node/ip-10-0-136-127.ec2.internal reason/FailedCreatePodSandBox Failed to create pod sandbox: rpc error: code = Unknown desc = `/usr/bin/runc --root /run/runc start 8c0f446a56629c9f00797f1b75fdbf64a6dc0c51b8c771ecbec2a8076205365e` failed: time="2020-04-29T01:22:26Z" level=error msg="container process is already dead"\ncontainer process is already dead\n  (exit status 1)

/test e2e-aws-seria

e2e-gcp failed due to:

ERROR: (gcloud.compute.instance-groups.list-instances) could not parse resource []

/test e2e-gcp

@danehans
Copy link
Contributor Author

Same aws-serial CI job failure symptom.

/test e2e-aws-serial

@danehans
Copy link
Contributor Author

Same e2e-gcp job error as #24927 (comment).
/test e2e-gcp

1 similar comment
@danehans
Copy link
Contributor Author

Same e2e-gcp job error as #24927 (comment).
/test e2e-gcp

@smarterclayton
Copy link
Contributor

/approve

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danehans, Miciah, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 44d2daa into openshift:master Apr 30, 2020
@openshift-ci-robot
Copy link

@danehans: All pull requests linked via external trackers have merged: openshift/origin#24927. Bugzilla bug 1822286 has been moved to the MODIFIED state.

In response to this:

Bug 1822286: Serializes k8s IngressClass test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 16, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: CryptoGodfatherVA, danehans, Miciah, smarterclayton

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smarterclayton smarterclayton smarterclayton left review comments

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@ironcladlou ironcladlou

@smarterclayton smarterclayton

@Miciah Miciah

@knobunc knobunc

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@danehans @openshift-ci-robot @Miciah @smarterclayton @openshift-bot @ironcladlou @knobunc @openshift-merge-robot