Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-4.3] Bug 1830085: Fix nil reference when accessing un-migrated platform status #24938

Conversation

openshift-cherrypick-robot

This is an automated cherry-pick of #24708

/assign danehans

Fix nil reference crashes when accessing an infrastructure status field that
hasn't been migrated.
@openshift-ci-robot
Copy link

@openshift-cherrypick-robot: Bugzilla bug 1814357 has been cloned as Bugzilla bug 1830085. Retitling PR to link against new bug.
/retitle [release-4.3] Bug 1830085: Fix nil reference when accessing un-migrated platform status

In response to this:

[release-4.3] Bug 1814357: Fix nil reference when accessing un-migrated platform status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] Bug 1814357: Fix nil reference when accessing un-migrated platform status [release-4.3] Bug 1830085: Fix nil reference when accessing un-migrated platform status Apr 30, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign smarterclayton
You can assign the PR to them by writing /assign @smarterclayton in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Miciah
Copy link
Contributor

Miciah commented Apr 30, 2020

We should get #24718 too.

@danehans
Copy link
Contributor

prow/images failed due to:

error: could not run steps: step hyperkube failed: could not wait for build: the build hyperkube failed after 0s with reason BuildPodDeleted: The pod for this build was deleted before the build completed.

/test images

@danehans
Copy link
Contributor

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label Apr 30, 2020
@openshift-ci-robot
Copy link

@danehans: This pull request references Bugzilla bug 1830085, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "---" instead
  • expected dependent Bugzilla bug 1814357 to target a release in 4.4.0, 4.4.z, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Apr 30, 2020
@danehans
Copy link
Contributor

Superseded by #24939

@danehans
Copy link
Contributor

/close

@openshift-ci-robot
Copy link

@danehans: Closed this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants