Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug 1814357: Fix nil reference when accessing un-migrated platform status #24708

Merged
merged 1 commit into from
Mar 18, 2020
Merged

Bug 1814357: Fix nil reference when accessing un-migrated platform status #24708

merged 1 commit into from
Mar 18, 2020

Conversation

ironcladlou
Copy link
Contributor

Fix nil reference crashes when accessing an infrastructure status field that
hasn't been migrated.

@ironcladlou
Fix nil reference when accessing un-migrated platform status
d699324 
Fix nil reference crashes when accessing an infrastructure status field that
hasn't been migrated.
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 17, 2020
@ironcladlou ironcladlou changed the title Fix nil reference when accessing un-migrated platform status Bug 1814357: Fix nil reference when accessing un-migrated platform status Mar 17, 2020
@openshift-ci-robot
Copy link

@ironcladlou: This pull request references Bugzilla bug 1814357, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1814357: Fix nil reference when accessing un-migrated platform status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2020
@ironcladlou
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 17, 2020
@openshift-ci-robot
Copy link

@ironcladlou: This pull request references Bugzilla bug 1814357, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 17, 2020
@ironcladlou
Copy link
Contributor Author

/test e2e-aws-upgrade-4.1-to-4.2-to-4.3-to-4.4-nightly

@Miciah
Copy link
Contributor

Miciah commented Mar 17, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 17, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ironcladlou, Miciah

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@ironcladlou
Copy link
Contributor Author

/retest

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

frobware
frobware reviewed Mar 17, 2020
View reviewed changes
test/extended/router/headers.go
switch platformType {
case configv1.AWSPlatformType, configv1.AzurePlatformType, configv1.GCPPlatformType:
// supported
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't the logging line below still a nil deref?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch. Opened #24718

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d9de5ca into openshift:master Mar 18, 2020
@openshift-ci-robot
Copy link

@ironcladlou: All pull requests linked via external trackers have merged. Bugzilla bug 1814357 has been moved to the MODIFIED state.

In response to this:

Bug 1814357: Fix nil reference when accessing un-migrated platform status

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ironcladlou ironcladlou mentioned this pull request Mar 19, 2020
Merged
@danehans
Copy link
Contributor

/cherry-pick release-4.3

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Apr 30, 2020
Closed
@openshift-cherrypick-robot
Copy link

@danehans: new pull request created: #24938

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans
Copy link
Contributor

/cherry-pick release-4.4

@openshift-cherrypick-robot
Copy link

@danehans: #24708 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/router/headers.go
M	test/extended/router/metrics.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/router/headers.go
CONFLICT (content): Merge conflict in test/extended/router/headers.go
Patch failed at 0001 Fix nil reference when accessing un-migrated platform status

In response to this:

/cherry-pick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@danehans danehans mentioned this pull request Apr 30, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware frobware left review comments

@knobunc knobunc Awaiting requested review from knobunc

@mfojtik mfojtik Awaiting requested review from mfojtik

Assignees

@Miciah Miciah

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ironcladlou @openshift-ci-robot @Miciah @openshift-bot @danehans @openshift-cherrypick-robot @frobware @openshift-merge-robot