Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1833387: test/extended/operators/operators: Drop cvoWait and operatorWait #24993

Merged

Conversation

wking
Copy link
Member

@wking wking commented May 15, 2020

We've had these since 5ff7aed (#21459), but conditions like ClusterVersion Progressing=True and ClusterOperator Degraded=True are serious enough that we don't want to see them post-install. Make it fatal to see those surprises at all, instead of giving operators a pass during an arbitrary post-install recovery window.

@openshift-ci-robot openshift-ci-robot added the bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. label May 15, 2020
@openshift-ci-robot
Copy link

@wking: This pull request references Bugzilla bug 1833387, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1833387: test/extended/operators/operators: Drop cvoWait and operatorWait

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label May 15, 2020
@wking
Copy link
Member Author

wking commented May 15, 2020

/assign @smarterclayton

We've had these since 5ff7aed (tests: Create a new test binary that
can be used instead of extended.tests, 2018-11-09, openshift#21459), but
conditions like ClusterVersion Progressing=True and ClusterOperator
Degraded=True are serious enough that we don't want to see them
post-install.  Make it fatal to see those surprises at all, instead of
giving operators a pass during an arbitrary post-install recovery
window.
@wking wking force-pushed the drop-wait-for-operator-health branch from 34e667b to 7fcf780 Compare May 15, 2020 23:52
@wking
Copy link
Member Author

wking commented May 16, 2020

e2e-gcp:

fail [github.com/openshift/origin/test/extended/operators/operators.go:94]: May 16 01:01:42.400: Some cluster operators are not ready: kube-apiserver (Progressing=True NodeInstaller: NodeInstallerProgressing: 1 nodes are at revision 2; 1 nodes are at revision 6; 1 nodes are at revision 8), kube-controller-manager (Progressing=True NodeInstaller: NodeInstallerProgressing: 2 nodes are at revision 7; 1 nodes are at revision 8), kube-scheduler (Progressing=True NodeInstaller: NodeInstallerProgressing: 1 nodes are at revision 7; 2 nodes are at revision 10)

So with this and #24992, we should be all set.

@sdodson
Copy link
Member

sdodson commented May 28, 2020

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2020
@sdodson sdodson added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2020
@wking
Copy link
Member Author

wking commented May 28, 2020

/retest

Now that #24992 has landed.

@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: sdodson, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 65667f2 into openshift:master May 29, 2020
@openshift-ci-robot
Copy link

@wking: All pull requests linked via external trackers have merged: openshift/origin#24993, openshift/origin#24992. Bugzilla bug 1833387 has been moved to the MODIFIED state.

In response to this:

Bug 1833387: test/extended/operators/operators: Drop cvoWait and operatorWait

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@wking wking deleted the drop-wait-for-operator-health branch May 29, 2020 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-high Referenced Bugzilla bug's severity is high for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants