New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1833387: test/extended/operators/operators: Drop cvoWait and operatorWait #24993
Bug 1833387: test/extended/operators/operators: Drop cvoWait and operatorWait #24993
Conversation
@wking: This pull request references Bugzilla bug 1833387, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/assign @smarterclayton |
We've had these since 5ff7aed (tests: Create a new test binary that can be used instead of extended.tests, 2018-11-09, openshift#21459), but conditions like ClusterVersion Progressing=True and ClusterOperator Degraded=True are serious enough that we don't want to see them post-install. Make it fatal to see those surprises at all, instead of giving operators a pass during an arbitrary post-install recovery window.
34e667b
to
7fcf780
Compare
So with this and #24992, we should be all set. |
/lgtm |
/retest Now that #24992 has landed. |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
1 similar comment
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: sdodson, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@wking: All pull requests linked via external trackers have merged: openshift/origin#24993, openshift/origin#24992. Bugzilla bug 1833387 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
We've had these since 5ff7aed (#21459), but conditions like
ClusterVersion
Progressing=True
andClusterOperator
Degraded=True
are serious enough that we don't want to see them post-install. Make it fatal to see those surprises at all, instead of giving operators a pass during an arbitrary post-install recovery window.