Bug 1791739: Restart watches in DC e2e tests #25010
Conversation
openshift-ci-robot
added
do-not-merge/work-in-progress
|
@tnozicka: This pull request references Bugzilla bug 1791739, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
bugzilla/valid-bug
| if config.Status.ObservedGeneration >= dc.Generation { | ||
| return true, nil | ||
| } | ||
| return false, nil |
There was a problem hiding this comment.
Nit, this whole block can be simplified to:
return config.Status.ObservedGeneration >= dc.Generation, nil
|
/retest |
tnozicka
force-pushed
the
dc-watches
branch
2 times, most recently
from
19c368a
to
d9e6c2c
Compare
tnozicka
changed the title
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
|
infra flakes |
|
yum flake |
|
infra |
|
@tnozicka: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: soltysh, tnozicka The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@tnozicka: All pull requests linked via external trackers have merged: Bugzilla bug 1791739 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.5 |
|
@clnperez: new pull request created: #25499 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This makes DC e2e more resilient to apiserver hickups or badly configured loadbalancer.
/cc @soltysh