Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug 1839187: more upstream to installed template switch in image-eco (django) #25018

Conversation

gabemontero
Copy link
Contributor

@gabemontero gabemontero commented May 22, 2020

NOTE: there is no django template in the official OCP catalog that DOES NOT employ persistence.

The oc new-app https://github.com/slcorg/django-ex ultimately employ a non-persistent template that is in the upstream repo but is not marked for inclusion in OCP.

There was a push by PM a while back to focus on sample templates using persistence, so the lack of a non-persistent template make sense, especially with these SCL ones, who PM at the time would have focused on.

As such, as needed, test case checks will be adjusted to account for the fact that state is persisted in the PV.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 22, 2020
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1839187, which is invalid:

  • expected the bug to target the "4.5.0" release, but it targets "---" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

Bug 1839187: more upstream to installed template switch in image-eco (django)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

/bugzilla refresh

@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1839187, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels May 22, 2020
@gabemontero gabemontero force-pushed the more-scl-upstream-template-use branch 2 times, most recently from 424e29c to dd2c4d4 Compare May 26, 2020 00:24
@gabemontero
Copy link
Contributor Author

/retest

@gabemontero gabemontero force-pushed the more-scl-upstream-template-use branch from dd2c4d4 to af6f336 Compare May 26, 2020 17:20
@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1839187, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1839187: more upstream to installed template switch in image-eco (django)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot
Copy link

@gabemontero: This pull request references Bugzilla bug 1839187, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.5.0) matches configured target release for branch (4.5.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

In response to this:

Bug 1839187: more upstream to installed template switch in image-eco (django)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero
Copy link
Contributor Author

OK we have a passing image eco and django test using an official (and now persistent) template with https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/25018/pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem/224

/assign @adambkaplan

FYI - this change is needed to unblock any samples PRs that need to pass image eco.

@gabemontero
Copy link
Contributor Author

@adambkaplan just in case ... I added detail in the description about persistent / non-persistent based templates and the effects on all this

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

networking/auth/monitoring operators degraded on upgrade job

/retest

@gabemontero
Copy link
Contributor Author

OK we have all green tests

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2020
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2020
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

9 similar comments
@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 1bec683 into openshift:master May 28, 2020
@openshift-ci-robot
Copy link

@gabemontero: All pull requests linked via external trackers have merged: openshift/origin#25018. Bugzilla bug 1839187 has been moved to the MODIFIED state.

In response to this:

Bug 1839187: more upstream to installed template switch in image-eco (django)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the more-scl-upstream-template-use branch May 28, 2020 01:53
@gabemontero
Copy link
Contributor Author

/cherrypick release-4.4

@openshift-cherrypick-robot

@gabemontero: #25018 failed to apply on top of branch "release-4.4":

error: Failed to merge in the changes.
Using index info to reconstruct a base tree...
M	test/extended/image_ecosystem/s2i_python.go
Falling back to patching base and 3-way merge...
Auto-merging test/extended/image_ecosystem/s2i_python.go
CONFLICT (content): Merge conflict in test/extended/image_ecosystem/s2i_python.go
Patch failed at 0001 more upstream to installed template switch in image-eco (django this time)

In response to this:

/cherrypick release-4.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants