New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1839187: more upstream to installed template switch in image-eco (django) #25018
Bug 1839187: more upstream to installed template switch in image-eco (django) #25018
Conversation
@gabemontero: This pull request references Bugzilla bug 1839187, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/bugzilla refresh |
@gabemontero: This pull request references Bugzilla bug 1839187, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
424e29c
to
dd2c4d4
Compare
/retest |
dd2c4d4
to
af6f336
Compare
@gabemontero: This pull request references Bugzilla bug 1839187, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@gabemontero: This pull request references Bugzilla bug 1839187, which is valid. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
OK we have a passing image eco and django test using an official (and now persistent) template with https://deck-ci.apps.ci.l2s4.p1.openshiftapps.com/view/gcs/origin-ci-test/pr-logs/pull/25018/pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem/224 /assign @adambkaplan FYI - this change is needed to unblock any samples PRs that need to pass image eco. |
@adambkaplan just in case ... I added detail in the description about persistent / non-persistent based templates and the effects on all this |
/retest |
networking/auth/monitoring operators degraded on upgrade job /retest |
OK we have all green tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
9 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@gabemontero: All pull requests linked via external trackers have merged: openshift/origin#25018. Bugzilla bug 1839187 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherrypick release-4.4 |
@gabemontero: #25018 failed to apply on top of branch "release-4.4":
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
NOTE: there is no django template in the official OCP catalog that DOES NOT employ persistence.
The
oc new-app https://github.com/slcorg/django-ex
ultimately employ a non-persistent template that is in the upstream repo but is not marked for inclusion in OCP.There was a push by PM a while back to focus on sample templates using persistence, so the lack of a non-persistent template make sense, especially with these SCL ones, who PM at the time would have focused on.
As such, as needed, test case checks will be adjusted to account for the fact that state is persisted in the PV.