-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1839517: UPSTREAM: <carry>: kube-controller-manager: allow running bare kube-controller-manager #25037
Conversation
…ontroller-manager
@soltysh: This pull request references Bugzilla bug 1839517, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Can you go in the other direction. If we pass no openshift data in the openshift config, let's stop using it and only pass flags in the pod |
/retest |
return kerrors.NewAggregate(err) | ||
} | ||
return nil | ||
} | ||
|
||
// applyFlags stores the provided arguments onto a flag set, reporting any errors | ||
// encountered during the process. | ||
func applyFlags(args map[string][]string, flags flag.NamedFlagSets) []error { | ||
func applyFlags(args map[string][]string, flags *pflag.FlagSet) []error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is all this still needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we wire and pass these flag values, we can't break them. I don't want to end up in the situation where this stops working, although truth to be told, this never worked in past few releases 😓 In 4.6 this will be entirely dropped in favor of regular flag passing.
/retest |
2 similar comments
/retest |
/retest |
/lgtm |
good enough for half a release I guess |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: deads2k, mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest |
@soltysh: All pull requests linked via external trackers have merged: openshift/origin#25037. Bugzilla bug 1839517 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
No description provided.