New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug 1843407: oVirt, add oVirt as a provide to openshift tests #25057
Bug 1843407: oVirt, add oVirt as a provide to openshift tests #25057
Conversation
@Gal-Zaidman: This pull request references Bugzilla bug 1843407, which is invalid:
Comment In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
74ebde4
to
4dbf3c8
Compare
/bugzilla refresh |
@Gal-Zaidman: This pull request references Bugzilla bug 1843407, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/retest |
oVirt didn't get a chance to be added as a provider to Kubernetes e2e tests [1][2][3], So we need to be added to origin like IBM on [4]. This is needed for skipping tests for ovirt [5] [1] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/openstack/openstack.go [2] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/vsphere/vsphere.go [3] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/azure/azure.go [4] openshift#24817 [5] https://github.com/openshift/origin/blob/master/cmd/openshift-tests/provider.go#L57-L63 Signed-off-by: Gal-Zaidman <gzaidman@redhat.com>
4dbf3c8
to
2b37e87
Compare
/assign @smarterclayton |
Tested it locally and running: |
/assign @mfojtik |
/retest |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Gal-Zaidman, smarterclayton The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/retest Please review the full test history for this PR and help us cut down flakes. |
3 similar comments
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
/retest Please review the full test history for this PR and help us cut down flakes. |
@Gal-Zaidman: All pull requests linked via external trackers have merged: openshift/origin#25057. Bugzilla bug 1843407 has been moved to the MODIFIED state. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.5 |
/cherrypick release-4.5 |
@Gal-Zaidman: new pull request created: #25065 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
@Gal-Zaidman: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/origin\n ! [rejected] cherry-pick-25057-to-release-4.5 -> cherry-pick-25057-to-release-4.5 (fetch first)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/origin'\nhint: Updates were rejected because the remote contains work that you do\nhint: not have locally. This is usually caused by another repository pushing\nhint: to the same ref. You may want to first integrate the remote changes\nhint: (e.g., 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
/cherry-pick release-4.4 |
@Gal-Zaidman: new pull request created: #25066 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
oVirt didn't get a chance to be added as a provider to Kubernetes e2e tests [1][2][3], So we need to be added to origin like IBM on [4].
This is needed for skipping tests for ovirt [5]
[1] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/openstack/openstack.go
[2] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/vsphere/vsphere.go
[3] https://github.com/kubernetes-cn/kubernetes/blob/c3bec0bae43b4c46800a13f44534ce6cd14b5f40/test/e2e/framework/providers/azure/azure.go
[4] #24817
[5] https://github.com/openshift/origin/blob/master/cmd/openshift-tests/provider.go#L57-L63
Signed-off-by: Gal-Zaidman gzaidman@redhat.com